Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1034153002: Revert of Enable distance field text on Android. (Closed)

Created:
5 years, 9 months ago by Jvsquare
Modified:
5 years, 9 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, David Yen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable distance field text on Android. (patchset #1 id:1 of https://codereview.chromium.org/884793003/) Reason for revert: Apparently causing significant perf regressions in thread_times.key_silk_cases. Original issue's description: > Enable distance field text on Android. > > Sets the Android default for Ganesh-rendered text to use signed distance fields. > The non-Android default still disables distance fields. > > BUG=446722 > OWNERS=jam@chromium.org > > Committed: https://crrev.com/58c4e746a47894de46dbfaa978f163d2072df7e0 > Cr-Commit-Position: refs/heads/master@{#320272} TBR=vangelis@chromium.org,vmiura@chromium.org,djsollen@chromium.org,robertphillips@chromium.org,jam@chromium.org,robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=446722 Committed: https://crrev.com/db1fe33a91accc8cff13b4bb419db162cd5f9be0 Cr-Commit-Position: refs/heads/master@{#322369}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/renderer/render_thread_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Jvsquare
Created Revert of Enable distance field text on Android.
5 years, 9 months ago (2015-03-26 12:32:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034153002/1
5 years, 9 months ago (2015-03-26 12:32:53 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-26 12:32:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034153002/1
5 years, 9 months ago (2015-03-26 12:54:25 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-26 12:54:28 UTC) #9
tomhudson
lgtm
5 years, 9 months ago (2015-03-26 12:54:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034153002/1
5 years, 9 months ago (2015-03-26 12:54:38 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 12:55:06 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 12:55:35 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db1fe33a91accc8cff13b4bb419db162cd5f9be0
Cr-Commit-Position: refs/heads/master@{#322369}

Powered by Google App Engine
This is Rietveld 408576698