components/content_settings/core/common/content_settings.h - Issue 1034143002: Content settings clean-up: Clarify resource identifier & get rid of NO_RESOURCE_IDENTIFIER.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/common/content_settings.h

Issue 1034143002: Content settings clean-up: Clarify resource identifier & get rid of NO_RESOURCE_IDENTIFIER. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/platform_notification_service_impl.cc ('K') | « components/content_settings/core/browser/content_settings_provider.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/common/content_settings.h

diff --git a/components/content_settings/core/common/content_settings.h b/components/content_settings/core/common/content_settings.h

index 7f49a8c11d9fc217abb0211939f4b915d1923947..55da8f5c70070c302e43403d8cd6bda7e6973d22 100644

--- a/components/content_settings/core/common/content_settings.h

+++ b/components/content_settings/core/common/content_settings.h

@@ -57,6 +57,11 @@ struct RendererContentSettingRules {

ContentSettingsForOneType script_rules;

};

+class NoResourceIdentifier {

+ public:

+ static const std::string GetResourceIdentifier() { return std::string(); }

markusheintz_ 2015/03/27 10:27:34 Add private: DISALLOW_IMPLICIT_CONSTRUCTORS(No

Deepak 2015/03/27 11:40:04 Done.

+};

namespace content_settings {

// Enum containing the various source for content settings. Settings can be