Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1034083003: Mojom lexer. (Closed)

Created:
5 years, 9 months ago by azani
Modified:
5 years, 8 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+718 lines, -0 lines) Patch
M BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A mojom/BUILD.gn View 1 2 3 4 5 6 1 chunk +43 lines, -0 lines 0 comments Download
A mojom/lexer.h View 1 2 3 4 5 6 1 chunk +92 lines, -0 lines 0 comments Download
A mojom/lexer.cc View 1 2 3 4 5 6 1 chunk +420 lines, -0 lines 0 comments Download
A mojom/lexer_unittest.cc View 1 2 3 4 5 6 1 chunk +162 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
azani
5 years, 9 months ago (2015-03-26 16:49:47 UTC) #2
azani
On 2015/03/26 16:49:47, azani wrote: Thrung, You mentioned I will likely need to move those ...
5 years, 9 months ago (2015-03-27 20:51:21 UTC) #3
azani
ptal
5 years, 8 months ago (2015-03-31 23:13:16 UTC) #4
viettrungluu
Since this is all (private) implementation, there's no reason for the cpp/ and tests/ subdirectories.
5 years, 8 months ago (2015-03-31 23:18:25 UTC) #5
azani
ptal
5 years, 8 months ago (2015-03-31 23:29:26 UTC) #6
viettrungluu
lgtm
5 years, 8 months ago (2015-04-01 00:29:59 UTC) #7
azani
5 years, 8 months ago (2015-04-01 14:57:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as
fca71cac3e32f6da2e1e42e58996ca7660c13d45 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698