Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1034073004: add legacy pathop enums; fix uninitialized warning (Closed)

Created:
5 years, 9 months ago by caryclark
Modified:
5 years, 9 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add legacy pathop enums; fix uninitialized warning R=reed@google.com BUG=skia:3588 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Committed: https://skia.googlesource.com/skia/+/d8bc16b306f8453a86d0af070d68c327f4bb41eb

Patch Set 1 #

Patch Set 2 : temporarily define legacy pathops all the time #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M include/pathops/SkPathOps.h View 1 2 chunks +14 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsTSect.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
caryclark
please review public interface change
5 years, 9 months ago (2015-03-26 15:41:40 UTC) #1
reed1
lgtm lets add SK_SUPPORT_LEGACY_PATHOP_ENUMS to chrome/skia/config/SkUserConfig.h right away and land it.
5 years, 9 months ago (2015-03-26 15:42:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034073004/20001
5 years, 9 months ago (2015-03-26 15:49:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034073004/20001
5 years, 9 months ago (2015-03-26 16:05:07 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 16:05:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d8bc16b306f8453a86d0af070d68c327f4bb41eb

Powered by Google App Engine
This is Rietveld 408576698