Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1034063002: Cleanup: Rename two entries of 'direct_dependent_configs' to 'public_configs'. (Closed)

Created:
5 years, 9 months ago by tfarina
Modified:
5 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Rename two entries of 'direct_dependent_configs' to 'public_configs'. public_configs is the non-deprecated name of direct_dependent_configs. BUG=None TEST=gn gen out-gn R=brettw@chromium.org Committed: https://crrev.com/dcbe0bcee17ee96b50496df6f569fc87bcc89a5f Cr-Commit-Position: refs/heads/master@{#322363}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/config/linux/gtk/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
5 years, 9 months ago (2015-03-25 22:31:42 UTC) #1
brettw
lgtm
5 years, 9 months ago (2015-03-26 03:10:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034063002/1
5 years, 9 months ago (2015-03-26 12:10:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 12:14:03 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 12:15:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dcbe0bcee17ee96b50496df6f569fc87bcc89a5f
Cr-Commit-Position: refs/heads/master@{#322363}

Powered by Google App Engine
This is Rietveld 408576698