Yaron
2015/04/07 15:39:04
There's already base_java_test_support and content
There's already base_java_test_support and content_java_test_support so this is
getting confusing. Any reason not to include in base_java_test_support?
Further, in general, we don't break up a folder of java code into multiple
packages: i.e. chromium/test/driver, chromium/test/support are different
libraries. I think Chris has thoughts about making one java dir for everything
but until then I think it's clearer to separate top-level java folders as
projects and not packages within one. ISTM that you have two separable concepts:
a driver and a support library for use with that driver
jbudorick
2015/04/07 19:24:45
This is used both in base_java_test_support and in
On 2015/04/07 15:39:04, Yaron wrote:
> There's already base_java_test_support and content_java_test_support so this
is
> getting confusing. Any reason not to include in base_java_test_support?
>
This is used both in base_java_test_support and in build/apk_test.gypi because
it's used by both the gtests and instrumentation tests to dump results in a
format that Appurify understands.
> Further, in general, we don't break up a folder of java code into multiple
> packages: i.e. chromium/test/driver, chromium/test/support are different
> libraries. I think Chris has thoughts about making one java dir for everything
> but until then I think it's clearer to separate top-level java folders as
> projects and not packages within one. ISTM that you have two separable
concepts:
> a driver and a support library for use with that driver
I had thought that that was a product of gyp's quirks, but I don't have any
objections to splitting these into separate top-level java folders. Created:
testing/android/appurify_support
testing/android/driver
testing/android/native_test
testing/android/passenger
testing/android/reporter
Moving the preexisting code to testing/android/native_test added quite a bit to
this CL. I'd be open to splitting that into a separate CL; wdyt?
Issue 1034053002: [Android] Add an out-of-app instrumentation driver APK.
(Closed)
Created 5 years, 9 months ago by jbudorick
Modified 5 years, 8 months ago
Reviewers: Ted C, klundberg, Yaron, Lei Zhang, cjhopman, Torne
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 66