testing/android/driver/java/AndroidManifest.xml - Issue 1034053002: [Android] Add an out-of-app instrumentation driver APK.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: testing/android/driver/java/AndroidManifest.xml

Issue 1034053002: [Android] Add an out-of-app instrumentation driver APK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Passenger -> Broker Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/chrome_tests.gypi ('K') | « testing/android/broker/java/src/org/chromium/test/broker/OnDeviceInstrumentationBroker.java ('k') | testing/android/driver/java/src/org/chromium/test/driver/OnDeviceInstrumentationDriver.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!--

	3 Copyright 2015 The Chromium Authors. All rights reserved.

	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.

	6 -->

	7

	8 <manifest xmlns:android="http://schemas.android.com/apk/res/android"

	9 package="org.chromium.test.driver"

	10 android:versionCode="1"

	11 android:versionName="1.0">

	12

	13 <uses-sdk android:minSdkVersion="16" android:targetSdkVersion="21" />

	14

	15 <application android:label="OnDeviceInstrumentationDriver">

	16 <service android:exported="true"

	17 android:name="org.chromium.test.reporter.ReportingService"

	18 android:process=":results_reporting"/>
	Yaron 2015/04/18 00:22:58 This only has the one service, why specify android This only has the one service, why specify android::process? Or does it run separately from the Driver. If so, is that really desirable? I worry that the ReportingService will get killed for some reason and we fail to collect results. I imagine another way this could be done is with BroadcastReceivers. You could have one here in the driver which would just listen to broadcasts of events which the broker would supply. If you're concerned about potential crosstalk between apps, you could have an identifier for each run that's included with the test result. I'm not sure that it's strictly better, but does simplify the service connection part and removes a process. wdyt? jbudorick 2015/04/20 19:21:38 Switched from service to dynamically registered Br Show quoted text On 2015/04/18 00:22:58, Yaron wrote: > This only has the one service, why specify android::process? Or does it run > separately from the Driver. If so, is that really desirable? I worry that the > ReportingService will get killed for some reason and we fail to collect results. > > I imagine another way this could be done is with BroadcastReceivers. You could > have one here in the driver which would just listen to broadcasts of events > which the broker would supply. If you're concerned about potential crosstalk > between apps, you could have an identifier for each run that's included with the > test result. I'm not sure that it's strictly better, but does simplify the > service connection part and removes a process. wdyt? Switched from service to dynamically registered BroadcastReceiver. This dropped ~200 lines from this CL and is much simpler.
	19 </application>

	20

	21 <instrumentation android:name="org.chromium.test.driver.OnDeviceInstrumentat ionDriver"

	22 android:targetPackage="org.chromium.test.driver"

	23 android:label="OnDeviceInstrumentationDriver"/>

	24

	25 <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>

	26

	27 </manifest>

OLD	NEW