Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1034033004: Make the canvas draw looper setup update the canvas save count (Closed)

Created:
5 years, 8 months ago by reed1
Modified:
5 years, 8 months ago
Reviewers:
Kimmo Kinnunen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make the canvas draw looper setup update the canvas save count Image filter in a paint would leave save count in wrong state for normal draws. This could be observed through the canvas references during the draw call. An example of this is inspecting the canvas during a draw looper. patch from issue 993863002 at patchset 20001 (http://crrev.com/993863002#ps20001) BUG=skia: TBR=kkinnunen@nvidia.com Committed: https://skia.googlesource.com/skia/+/fd3a91e1fc4de69611b5297f624a1cd65db4ced1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -4 lines) Patch
M gyp/tests.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 5 chunks +4 lines, -3 lines 0 comments Download
A tests/DrawLooperTest.cpp View 1 chunk +92 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
reed1
5 years, 8 months ago (2015-03-26 20:23:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034033004/1
5 years, 8 months ago (2015-03-26 20:24:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/fd3a91e1fc4de69611b5297f624a1cd65db4ced1
5 years, 8 months ago (2015-03-26 20:30:01 UTC) #5
reed1
5 years, 8 months ago (2015-03-26 20:39:45 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1037653004/ by reed@google.com.

The reason for reverting is: makes internalSave and internalSaveLayer
inconsistent. Need to find a different solution..

Powered by Google App Engine
This is Rietveld 408576698