Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1033983002: Add serializers to RTCIceCandidate and RTCSessionDescription (Closed)

Created:
5 years, 9 months ago by Jens Widell
Modified:
5 years, 9 months ago
CC:
blink-reviews, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@idl-serializer
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add serializers to RTCIceCandidate and RTCSessionDescription Support for the serializer syntax was added by these CLs: https://codereview.chromium.org/1031593003/ https://codereview.chromium.org/1004503004/ The V8ObjectBuilder helper class was added by this CL: https://codereview.chromium.org/1031783003/ BUG=469650, 468180 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192621

Patch Set 1 #

Patch Set 2 : fix global-interface-listing expectation #

Messages

Total messages: 14 (5 generated)
Jens Widell
PTAL
5 years, 9 months ago (2015-03-26 09:32:11 UTC) #2
tommi (sloooow) - chröme
lgtm! awesome :D
5 years, 9 months ago (2015-03-26 09:51:59 UTC) #3
perkj_chrome
lgtm- thanks a lot!
5 years, 9 months ago (2015-03-26 10:32:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033983002/1
5 years, 9 months ago (2015-03-26 12:18:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/54433)
5 years, 9 months ago (2015-03-26 14:35:43 UTC) #8
Jens Widell
On 2015/03/26 14:35:43, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 9 months ago (2015-03-26 15:38:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033983002/20001
5 years, 9 months ago (2015-03-26 15:38:58 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=192621
5 years, 9 months ago (2015-03-26 18:33:45 UTC) #13
Peter Kasting
5 years, 9 months ago (2015-03-27 02:40:26 UTC) #14
Message was sent while issue was closed.
This might have caused a test failure (not sure); see http://crbug.com/471132 .

Powered by Google App Engine
This is Rietveld 408576698