Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1033973002: Reland [V8] Removed SourceLocationRestrict (Closed)

Created:
5 years, 9 months ago by kozy
Modified:
5 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland [V8] Removed SourceLocationRestrict This method uses in messages.js in GetSourceLine and GetPositionInLine. This methods uses in v8::Message API methods and there is no documentation about it. Method looks obsolete. One of the strange side effect is shown by attached issue. BUG=chromium:468781 TBR=yangguo@chromium.org LOG=Y Committed: https://crrev.com/aca928b7ad2153de472a592e2222e3e1bcc7b8b3 Cr-Commit-Position: refs/heads/master@{#27458}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -142 lines) Patch
M src/messages.js View 4 chunks +0 lines, -54 lines 0 comments Download
M test/mjsunit/debug-sourceinfo.js View 2 chunks +3 lines, -88 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
kozy
Original CL: https://codereview.chromium.org/1022333004/ I've disabled layout tests in CL: https://codereview.chromium.org/1032083002/ I am going to land ...
5 years, 9 months ago (2015-03-25 12:12:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033973002/1
5 years, 9 months ago (2015-03-25 12:12:27 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-25 12:12:29 UTC) #5
kozy
Yang, ptal. I need your owner lgtm for reland. Reason of reverting first version - ...
5 years, 9 months ago (2015-03-25 12:15:02 UTC) #6
Yang
On 2015/03/25 12:15:02, kozyatinskiy wrote: > Yang, ptal. I need your owner lgtm for reland. ...
5 years, 9 months ago (2015-03-25 12:37:07 UTC) #7
kozy
On 2015/03/25 12:37:07, Yang wrote: > On 2015/03/25 12:15:02, kozyatinskiy wrote: > > Yang, ptal. ...
5 years, 9 months ago (2015-03-25 12:50:44 UTC) #8
Yang
On 2015/03/25 12:50:44, kozyatinskiy wrote: > On 2015/03/25 12:37:07, Yang wrote: > > On 2015/03/25 ...
5 years, 9 months ago (2015-03-25 12:54:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033973002/20001
5 years, 9 months ago (2015-03-25 22:55:44 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-25 23:11:06 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 23:11:21 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aca928b7ad2153de472a592e2222e3e1bcc7b8b3
Cr-Commit-Position: refs/heads/master@{#27458}

Powered by Google App Engine
This is Rietveld 408576698