Issue 1033963002: Oilpan: finalization of Permissions and SyncManager not needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1033963002: Oilpan: finalization of Permissions and SyncManager not needed. (Closed)

Created:
5 years, 9 months ago by sof

Modified:
5 years, 9 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: finalization of Permissions and SyncManager not needed. With ScriptWrappable being without a destructor with Oilpan, have these two classes derive from the non-finalizing GarbageCollected<>. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192536

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -14 lines)			Patch
M	Source/modules/background_sync/SyncManager.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/modules/permissions/Permissions.h	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	Source/modules/permissions/Permissions.cpp	View	2 chunks	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033963002/1

5 years, 9 months ago (2015-03-25 13:20:32 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-25 13:24:18 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192536

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages