Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Side by Side Diff: Source/core/editing/SimplifyMarkupCommand.cpp

Issue 1033943002: Rename LayoutStyle to papayawhip (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: ensureComputedStyle Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/editing/EditorCommand.cpp ('k') | Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "config.h" 26 #include "config.h"
27 #include "core/editing/SimplifyMarkupCommand.h" 27 #include "core/editing/SimplifyMarkupCommand.h"
28 28
29 #include "core/dom/NodeLayoutStyle.h" 29 #include "core/dom/NodeComputedStyle.h"
30 #include "core/dom/NodeTraversal.h" 30 #include "core/dom/NodeTraversal.h"
31 #include "core/layout/LayoutInline.h" 31 #include "core/layout/LayoutInline.h"
32 #include "core/layout/LayoutObject.h" 32 #include "core/layout/LayoutObject.h"
33 #include "core/layout/style/LayoutStyle.h" 33 #include "core/layout/style/ComputedStyle.h"
34 34
35 namespace blink { 35 namespace blink {
36 36
37 SimplifyMarkupCommand::SimplifyMarkupCommand(Document& document, Node* firstNode , Node* nodeAfterLast) 37 SimplifyMarkupCommand::SimplifyMarkupCommand(Document& document, Node* firstNode , Node* nodeAfterLast)
38 : CompositeEditCommand(document), m_firstNode(firstNode), m_nodeAfterLast(no deAfterLast) 38 : CompositeEditCommand(document), m_firstNode(firstNode), m_nodeAfterLast(no deAfterLast)
39 { 39 {
40 } 40 }
41 41
42 void SimplifyMarkupCommand::doApply() 42 void SimplifyMarkupCommand::doApply()
43 { 43 {
44 ContainerNode* rootNode = m_firstNode->parentNode(); 44 ContainerNode* rootNode = m_firstNode->parentNode();
45 WillBeHeapVector<RefPtrWillBeMember<ContainerNode>> nodesToRemove; 45 WillBeHeapVector<RefPtrWillBeMember<ContainerNode>> nodesToRemove;
46 46
47 // Walk through the inserted nodes, to see if there are elements that could be removed 47 // Walk through the inserted nodes, to see if there are elements that could be removed
48 // without affecting the style. The goal is to produce leaner markup even wh en starting 48 // without affecting the style. The goal is to produce leaner markup even wh en starting
49 // from a verbose fragment. 49 // from a verbose fragment.
50 // We look at inline elements as well as non top level divs that don't have attributes. 50 // We look at inline elements as well as non top level divs that don't have attributes.
51 for (Node* node = m_firstNode.get(); node && node != m_nodeAfterLast; node = NodeTraversal::next(*node)) { 51 for (Node* node = m_firstNode.get(); node && node != m_nodeAfterLast; node = NodeTraversal::next(*node)) {
52 if (node->hasChildren() || (node->isTextNode() && node->nextSibling())) 52 if (node->hasChildren() || (node->isTextNode() && node->nextSibling()))
53 continue; 53 continue;
54 54
55 ContainerNode* startingNode = node->parentNode(); 55 ContainerNode* startingNode = node->parentNode();
56 if (!startingNode) 56 if (!startingNode)
57 continue; 57 continue;
58 const LayoutStyle* startingStyle = startingNode->layoutStyle(); 58 const ComputedStyle* startingStyle = startingNode->computedStyle();
59 if (!startingStyle) 59 if (!startingStyle)
60 continue; 60 continue;
61 ContainerNode* currentNode = startingNode; 61 ContainerNode* currentNode = startingNode;
62 ContainerNode* topNodeWithStartingStyle = nullptr; 62 ContainerNode* topNodeWithStartingStyle = nullptr;
63 while (currentNode != rootNode) { 63 while (currentNode != rootNode) {
64 if (currentNode->parentNode() != rootNode && isRemovableBlock(curren tNode)) 64 if (currentNode->parentNode() != rootNode && isRemovableBlock(curren tNode))
65 nodesToRemove.append(currentNode); 65 nodesToRemove.append(currentNode);
66 66
67 currentNode = currentNode->parentNode(); 67 currentNode = currentNode->parentNode();
68 if (!currentNode) 68 if (!currentNode)
69 break; 69 break;
70 70
71 if (!currentNode->layoutObject() || !currentNode->layoutObject()->is LayoutInline() || toLayoutInline(currentNode->layoutObject())->alwaysCreateLineB oxes()) 71 if (!currentNode->layoutObject() || !currentNode->layoutObject()->is LayoutInline() || toLayoutInline(currentNode->layoutObject())->alwaysCreateLineB oxes())
72 continue; 72 continue;
73 73
74 if (currentNode->firstChild() != currentNode->lastChild()) { 74 if (currentNode->firstChild() != currentNode->lastChild()) {
75 topNodeWithStartingStyle = 0; 75 topNodeWithStartingStyle = 0;
76 break; 76 break;
77 } 77 }
78 78
79 if (!currentNode->layoutStyle()->visualInvalidationDiff(*startingSty le).hasDifference()) 79 if (!currentNode->computedStyle()->visualInvalidationDiff(*startingS tyle).hasDifference())
80 topNodeWithStartingStyle = currentNode; 80 topNodeWithStartingStyle = currentNode;
81 81
82 } 82 }
83 if (topNodeWithStartingStyle) { 83 if (topNodeWithStartingStyle) {
84 for (ContainerNode* node = startingNode; node != topNodeWithStarting Style; node = node->parentNode()) 84 for (ContainerNode* node = startingNode; node != topNodeWithStarting Style; node = node->parentNode())
85 nodesToRemove.append(node); 85 nodesToRemove.append(node);
86 } 86 }
87 } 87 }
88 88
89 // we perform all the DOM mutations at once. 89 // we perform all the DOM mutations at once.
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 } 122 }
123 123
124 DEFINE_TRACE(SimplifyMarkupCommand) 124 DEFINE_TRACE(SimplifyMarkupCommand)
125 { 125 {
126 visitor->trace(m_firstNode); 126 visitor->trace(m_firstNode);
127 visitor->trace(m_nodeAfterLast); 127 visitor->trace(m_nodeAfterLast);
128 CompositeEditCommand::trace(visitor); 128 CompositeEditCommand::trace(visitor);
129 } 129 }
130 130
131 } // namespace blink 131 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/editing/EditorCommand.cpp ('k') | Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698