Source/core/svg/animation/SMILTimeContainer.cpp - Issue 103393002: Use DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION to generate toSVGSMILElement()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/animation/SMILTimeContainer.cpp

Issue 103393002: Use DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION to generate toSVGSMILElement() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/animation/SMILTimeContainer.cpp

diff --git a/Source/core/svg/animation/SMILTimeContainer.cpp b/Source/core/svg/animation/SMILTimeContainer.cpp

index 3174ea6fc5d923dde8ba3dc65f778ea1d9eb34d8..771db6d009b3d7787e102aa776c7eae38b425698 100644

--- a/Source/core/svg/animation/SMILTimeContainer.cpp

+++ b/Source/core/svg/animation/SMILTimeContainer.cpp

@@ -229,7 +229,7 @@ void SMILTimeContainer::updateDocumentOrderIndexes()

{

unsigned timingElementCount = 0;

for (Element* element = m_ownerSVGElement; element; element = ElementTraversal::next(*element, m_ownerSVGElement)) {

- if (SVGSMILElement::isSMILElement(element))

+ if (element && isSVGSMILElement(*element))

tkent 2013/12/04 03:50:02 |element &&| is redundant because the |for| condit

toSVGSMILElement(element)->setDocumentOrderIndex(timingElementCount++);

}

m_documentOrderIndexesDirty = false;

« no previous file with comments | « Source/core/svg/SVGAElement.cpp ('k') | Source/core/svg/animation/SVGSMILElement.h » ('j') | Source/core/svg/animation/SVGSMILElement.cpp » ('J')