Touch Events capability negotiation

remoting/host/basic_desktop_environment.h

Index: remoting/host/basic_desktop_environment.h
diff --git a/remoting/host/basic_desktop_environment.h b/remoting/host/basic_desktop_environment.h
index 6b6b8e25ede0e94a14c63af789926a45a7a8e130..bd1ae1ced25db179d2d9ea81c4aa99eb81f8a54c 100644
--- a/remoting/host/basic_desktop_environment.h
+++ b/remoting/host/basic_desktop_environment.h
@@ -64,6 +64,11 @@ class BasicDesktopEnvironment : public DesktopEnvironment {
     return desktop_capture_options_.get();
   }
 
+  // Enables or disables touch events capability.

[Wez, 2015/05/21 00:59:14]

nit: This comment doesn't really add anything.

[Rintaro Kuroiwa, 2015/05/21 21:53:29]

Done. REmoved.

+  void set_supports_touch_events(bool enable) {

[Wez, 2015/05/21 00:59:14]

Do you need this setter, or can you just make it a ctor parameter?

[Rintaro Kuroiwa, 2015/05/21 21:53:29]

No we don't. It just requires changes to classes that inherit this. changed.

+    supports_touch_events_ = enable;
+  }
+
  private:
   // Task runner on which methods of DesktopEnvironment interface should be
   // called.
@@ -82,6 +87,9 @@ class BasicDesktopEnvironment : public DesktopEnvironment {
   // find build errors.
   scoped_ptr<webrtc::DesktopCaptureOptions> desktop_capture_options_;
 
+  // True if the desktop environment supports touch events capability.

[Wez, 2015/05/21 00:59:14]

nit: True if the touch events capability should be offered.

[Rintaro Kuroiwa, 2015/05/21 21:53:29]

Done.

+  bool supports_touch_events_;
+
   DISALLOW_COPY_AND_ASSIGN(BasicDesktopEnvironment);
 };
 
@@ -110,6 +118,12 @@ class BasicDesktopEnvironmentFactory : public DesktopEnvironmentFactory {
     return ui_task_runner_;
   }
 
+  // Enables or disables touch events capability.

[Wez, 2015/05/21 00:59:14]

It actually configures whether DesktopEnvironments created by this factory
advertise the capability, right?

[Rintaro Kuroiwa, 2015/05/21 21:53:29]

Removed this comment since these are just accessors.  changed the comment for
the bool.

+  void set_supports_touch_events(bool enable) {
+    supports_touch_events_ = enable;
+  }
+  bool supports_touch_events() const { return supports_touch_events_; }
+
  private:
   // Task runner on which methods of DesktopEnvironmentFactory interface should
   // be called.
@@ -121,6 +135,10 @@ class BasicDesktopEnvironmentFactory : public DesktopEnvironmentFactory {
   // Used to run UI code.
   scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
 
+  // If true then the newly Create()ed desktop environments support touch
+  // events.

[Wez, 2015/05/21 00:59:14]

Suggest phrasing this the same as the equivalent comment in the
DesktopEnvironment.

[Rintaro Kuroiwa, 2015/05/21 21:53:29]

Done.

+  bool supports_touch_events_;
+
   DISALLOW_COPY_AND_ASSIGN(BasicDesktopEnvironmentFactory);
 };