remoting/host/multi_touch_capability.cc - Issue 1033913003: Touch Events capability negotiation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/host/multi_touch_capability.cc

Issue 1033913003: Touch Events capability negotiation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "remoting/host/multi_touch_capability.h"

	6

	7 #include "base/logging.h"

	8

	9 #if defined(OS_WIN)

	10 #include "remoting/host/touch_injector_win.h"

	11 #endif // defined(OS_WIN)

	12

	13 namespace remoting {

	14

	15 bool MultiTouchCapable() {

	16 #if defined(OS_WIN)

	17 return TouchInjectorWinDelegate::Create().get() != nullptr;
	Wez 2015/03/30 17:10:07 nit: You can test a scoped_ptr<> directly as a boo nit: You can test a scoped_ptr<> directly as a bool, so it'd be clearer to assign this to a local scoped_ptr<> \|foo\| and then return \|foo\|, I think. Rintaro Kuroiwa 2015/04/08 03:27:43 Done. Also moved this to InputInjector<platform>:: Show quoted text On 2015/03/30 17:10:07, Wez wrote: > nit: You can test a scoped_ptr<> directly as a bool, so it'd be clearer to > assign this to a local scoped_ptr<> \|foo\| and then return \|foo\|, I think. Done. Also moved this to InputInjector<platform>::CanInjectTouch().
	18 #else // !defined(OS_WIN)

	19 return false;

	20 #endif // defined(OS_WIN)

	21 }

	22

	23 } // namespace remoting

OLD	NEW