Touch Events capability negotiation

remoting/client/plugin/chromoting_instance.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/plugin/chromoting_instance.h"
 
 #include <string>
 #include <vector>
 
 #if defined(OS_NACL)
@@ skipping 161 matching lines @@
 
 }  // namespace
 
 // String sent in the "hello" message to the webapp to describe features.
 const char ChromotingInstance::kApiFeatures[] =
     "highQualityScaling injectKeyEvent sendClipboardItem remapKey trapKey "
     "notifyClientResolution pauseVideo pauseAudio asyncPin thirdPartyAuth "
     "pinlessAuth extensionMessage allowMouseLock videoControl";
 
 const char ChromotingInstance::kRequestedCapabilities[] = "";
-const char ChromotingInstance::kSupportedCapabilities[] = "desktopShape";
+const char ChromotingInstance::kSupportedCapabilities[] =
+    "desktopShape multiTouch";

[Wez, 2015/03/30 17:10:07]

Do you mean to add multiTouch capability here? You've already got the web-app
handling the capability negotiation.

[Rintaro Kuroiwa, 2015/04/08 03:27:42]

I'm not very good at javascript :(
I found out that I could put it in webapp/base/js/application.js or just put it
here. I'll put it in application.js, where all the other app capabilities are
set.

[Wez, 2015/04/09 22:58:59]

My point is more that there are two sets of capability negotiations:
1. client <-> host (i.e. protocol level)
2. web-app <-> plugin (we needed this because the plugin used to be in-built to
Chrome).

If you add a capability here then it's #2, whereas I think you want #1?

[Rintaro Kuroiwa, 2015/04/20 18:20:03]

Oh I see. Yes I meant to do #1.

 
 ChromotingInstance::ChromotingInstance(PP_Instance pp_instance)
     : pp::Instance(pp_instance),
       initialized_(false),
       plugin_task_runner_(new PluginThreadTaskRunner(&plugin_thread_delegate_)),
       context_(plugin_task_runner_.get()),
       input_tracker_(&mouse_input_filter_),
       touch_input_scaler_(&input_tracker_),
       key_mapper_(&touch_input_scaler_),
       input_handler_(&input_tracker_),
@@ skipping 995 matching lines @@
 
 #if !defined(OS_NACL)
   // Log messages are forwarded to the webapp only in PNaCl version of the
   // plugin, so ProcessLogToUI() needs to be called explicitly in the non-PNaCl
   // version.
   ProcessLogToUI(message);
 #endif  // !defined(OS_NACL)
 }
 
 }  // namespace remoting