Touch Events capability negotiation

remoting/host/basic_desktop_environment.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_BASIC_DESKTOP_ENVIRONMENT_H_
 #define REMOTING_HOST_BASIC_DESKTOP_ENVIRONMENT_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 46 matching lines @@
   }
 
   scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner() const {
     return ui_task_runner_;
   }
 
   webrtc::DesktopCaptureOptions* desktop_capture_options() {
     return desktop_capture_options_.get();
   }
 
+  // Enables or disables touch events capability.

[Wez, 2015/05/21 00:59:14]

nit: This comment doesn't really add anything.

[Rintaro Kuroiwa, 2015/05/21 21:53:29]

Done. REmoved.

+  void set_supports_touch_events(bool enable) {

[Wez, 2015/05/21 00:59:14]

Do you need this setter, or can you just make it a ctor parameter?

[Rintaro Kuroiwa, 2015/05/21 21:53:29]

No we don't. It just requires changes to classes that inherit this. changed.

+    supports_touch_events_ = enable;
+  }
+
  private:
   // Task runner on which methods of DesktopEnvironment interface should be
   // called.
   scoped_refptr<base::SingleThreadTaskRunner> caller_task_runner_;
 
   // Used to run input-related tasks.
   scoped_refptr<base::SingleThreadTaskRunner> input_task_runner_;
 
   // Used to run UI code.
   scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
 
   // Options shared between |DesktopCapturer| and |MouseCursorMonitor|. It
   // might contain expensive resources, thus justifying the sharing.
   // Also: it's dynamically allocated to avoid having to bring in
   // desktop_capture_options.h which brings in X11 headers which causes hard to
   // find build errors.
   scoped_ptr<webrtc::DesktopCaptureOptions> desktop_capture_options_;
 
+  // True if the desktop environment supports touch events capability.

[Wez, 2015/05/21 00:59:14]

nit: True if the touch events capability should be offered.

[Rintaro Kuroiwa, 2015/05/21 21:53:29]

Done.

+  bool supports_touch_events_;
+
   DISALLOW_COPY_AND_ASSIGN(BasicDesktopEnvironment);
 };
 
 // Used to create |BasicDesktopEnvironment| instances.
 class BasicDesktopEnvironmentFactory : public DesktopEnvironmentFactory {
  public:
   BasicDesktopEnvironmentFactory(
       scoped_refptr<base::SingleThreadTaskRunner> caller_task_runner,
       scoped_refptr<base::SingleThreadTaskRunner> input_task_runner,
       scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner);
   ~BasicDesktopEnvironmentFactory() override;
 
   // DesktopEnvironmentFactory implementation.
   bool SupportsAudioCapture() const override;
 
  protected:
   scoped_refptr<base::SingleThreadTaskRunner> caller_task_runner() const {
     return caller_task_runner_;
   }
 
   scoped_refptr<base::SingleThreadTaskRunner> input_task_runner() const {
     return input_task_runner_;
   }
 
   scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner() const {
     return ui_task_runner_;
   }
 
+  // Enables or disables touch events capability.

[Wez, 2015/05/21 00:59:14]

It actually configures whether DesktopEnvironments created by this factory
advertise the capability, right?

[Rintaro Kuroiwa, 2015/05/21 21:53:29]

Removed this comment since these are just accessors.  changed the comment for
the bool.

+  void set_supports_touch_events(bool enable) {
+    supports_touch_events_ = enable;
+  }
+  bool supports_touch_events() const { return supports_touch_events_; }
+
  private:
   // Task runner on which methods of DesktopEnvironmentFactory interface should
   // be called.
   scoped_refptr<base::SingleThreadTaskRunner> caller_task_runner_;
 
   // Used to run input-related tasks.
   scoped_refptr<base::SingleThreadTaskRunner> input_task_runner_;
 
   // Used to run UI code.
   scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
 
+  // If true then the newly Create()ed desktop environments support touch
+  // events.

[Wez, 2015/05/21 00:59:14]

Suggest phrasing this the same as the equivalent comment in the
DesktopEnvironment.

[Rintaro Kuroiwa, 2015/05/21 21:53:29]

Done.

+  bool supports_touch_events_;
+
   DISALLOW_COPY_AND_ASSIGN(BasicDesktopEnvironmentFactory);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_BASIC_DESKTOP_ENVIRONMENT_H_