Touch Events capability negotiation

remoting/host/basic_desktop_environment.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/basic_desktop_environment.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/single_thread_task_runner.h"
 #include "remoting/host/audio_capturer.h"
 #if defined(OS_CHROMEOS)
 #include "remoting/host/chromeos/aura_desktop_capturer.h"
 #include "remoting/host/chromeos/mouse_cursor_monitor_aura.h"
 #endif
 #include "remoting/host/client_session_control.h"
 #include "remoting/host/gnubby_auth_handler.h"
 #include "remoting/host/input_injector.h"
 #include "remoting/host/screen_controls.h"
 #include "third_party/webrtc/modules/desktop_capture/desktop_capture_options.h"
 #include "third_party/webrtc/modules/desktop_capture/mouse_cursor_monitor.h"
 #include "third_party/webrtc/modules/desktop_capture/screen_capturer.h"
 
 namespace remoting {
 
+namespace {
+const char kRawTouchEventsCapability[] = "rawTouchEvents";

[Wez, 2015/04/23 22:10:25]

Why "raw" touch events?

I think it'd be reasonable to call this touchEvents and we can then call a
subsequent addition touchEventsV2, touchGestures, touchActions, etc, as
necessary. :)

nit: Is there really no common location we can move this definition to? :-/

[Rintaro Kuroiwa, 2015/04/24 01:55:02]

Make sense :) will go with touchEvents.

I saw kRateLimitResizeRequests being duplicated so I also duplicated, maybe I'm
wrong because I only see kRateLimitResizeRequests in Me2MeDE and
DesktopSessionProxy (essentially IpcDE) which are both Me2Me. I guess the
translation unit scope prevents from accidentally setting it for It2Me sessions.

Seems overkill to add 'host_capabilities.h' just for this capability. Do you
think input_injector.h would be a reasonable place?

+}  // namespace
+
 BasicDesktopEnvironment::~BasicDesktopEnvironment() {
   DCHECK(caller_task_runner_->BelongsToCurrentThread());
 }
 
 scoped_ptr<AudioCapturer> BasicDesktopEnvironment::CreateAudioCapturer() {
   DCHECK(caller_task_runner_->BelongsToCurrentThread());
 
   return AudioCapturer::Create();
 }
 
@@ skipping 13 matching lines @@
 BasicDesktopEnvironment::CreateMouseCursorMonitor() {
 #if defined(OS_CHROMEOS)
   return make_scoped_ptr(new MouseCursorMonitorAura());
 #else
   return make_scoped_ptr(webrtc::MouseCursorMonitor::CreateForScreen(
       *desktop_capture_options_, webrtc::kFullDesktopScreenId));
 #endif
 }
 
 std::string BasicDesktopEnvironment::GetCapabilities() const {
+  if (supports_raw_touch_events_)
+    return kRawTouchEventsCapability;
+
   return std::string();
 }
 
 void BasicDesktopEnvironment::SetCapabilities(const std::string& capabilities) {
 }
 
 scoped_ptr<GnubbyAuthHandler> BasicDesktopEnvironment::CreateGnubbyAuthHandler(
     protocol::ClientStub* client_stub) {
   return nullptr;
 }
@@ skipping 14 matching lines @@
 
 BasicDesktopEnvironment::BasicDesktopEnvironment(
     scoped_refptr<base::SingleThreadTaskRunner> caller_task_runner,
     scoped_refptr<base::SingleThreadTaskRunner> input_task_runner,
     scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner)
     : caller_task_runner_(caller_task_runner),
       input_task_runner_(input_task_runner),
       ui_task_runner_(ui_task_runner),
       desktop_capture_options_(
           new webrtc::DesktopCaptureOptions(
-              webrtc::DesktopCaptureOptions::CreateDefault())) {
+              webrtc::DesktopCaptureOptions::CreateDefault())),
+      supports_raw_touch_events_(false) {
   DCHECK(caller_task_runner_->BelongsToCurrentThread());
 }
 
 BasicDesktopEnvironmentFactory::BasicDesktopEnvironmentFactory(
     scoped_refptr<base::SingleThreadTaskRunner> caller_task_runner,
     scoped_refptr<base::SingleThreadTaskRunner> input_task_runner,
     scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner)
     : caller_task_runner_(caller_task_runner),
       input_task_runner_(input_task_runner),
-      ui_task_runner_(ui_task_runner) {
+      ui_task_runner_(ui_task_runner),
+      supports_raw_touch_events_(false) {
 }
 
 BasicDesktopEnvironmentFactory::~BasicDesktopEnvironmentFactory() {
 }
 
 bool BasicDesktopEnvironmentFactory::SupportsAudioCapture() const {
   DCHECK(caller_task_runner_->BelongsToCurrentThread());
 
   return AudioCapturer::IsSupported();
 }
 
 }  // namespace remoting