Issue 1033913002: Menu in StocksApp should animate out

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1033913002: Menu in StocksApp should animate out (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
rafaelw, ojan

CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Menu in StocksApp should animate out This CL teaches PopupMenu how to animate out as well as in. Also, I've changed the PopupMenuItem animations to be driven from the PopupMenu itself, which makes it easier to run the animation in reverse when closing the menu. TBR=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5f10ef48b5c140e5cace75892054a5fdc32dab47

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -56 lines)			Patch
M	sky/examples/stocks-fn/lib/stock_app.dart	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	sky/framework/animation/animated_value.dart	View	3 chunks	+16 lines, -6 lines	0 comments	Download
M	sky/framework/components/popup_menu.dart	View	4 chunks	+26 lines, -38 lines	0 comments	Download
M	sky/framework/components/popup_menu_item.dart	View	1 chunk	+9 lines, -10 lines	0 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

5 years, 9 months ago (2015-03-25 17:40:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5f10ef48b5c140e5cace75892054a5fdc32dab47 (presubmit successful).