Make console.memory writeable

Make console.memory writeable

Since moving DOM properties to the prototype chain, writing to readonly
attributes throws in strict mode. As console.memory appears to be used
in a bunch of frameworks, and in addition is a chrome only feature, this
breaks a bunch of websites.

BUG=468611
R=haraken@chromium.org,dcarney@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192512

[haraken, 2015-03-25 08:03:07]

haraken@chromium.org changed reviewers:
+ yukishiino@chromium.org

[haraken, 2015-03-25 08:03:08]

I guess shiino-san has another idea for this.

[dcarney, 2015-03-25 08:04:28]

lgtm

[Yuki, 2015-03-25 08:43:39]

On 2015/03/25 08:04:28, dcarney wrote:
> lgtm

I'm okay with this CL except for one concern.

The new behavior is still different from the old one.

before:
  originalConsoleMemory = console.memory
  console.memory = "foo"
  console.memory == originalConsoleMemory
      => true

after:
  originalConsoleMemory = console.memory
  console.memory = "foo"
  console.memory == originalConsoleMemory
      => false

Is it okay?

I've changed my mind very recently, and think it'd be better to keep the
original behavior, i.e. ignore any assignments for the time being for the sake
of compatibility.

What do you think?

[Yuki, 2015-03-25 08:45:06]

On 2015/03/25 08:43:39, Yuki wrote:
> On 2015/03/25 08:04:28, dcarney wrote:
> > lgtm
> 
> I'm okay with this CL except for one concern.
> 
> The new behavior is still different from the old one.
> 
> before:
>   originalConsoleMemory = console.memory
>   console.memory = "foo"
>   console.memory == originalConsoleMemory
>       => true
> 
> after:
>   originalConsoleMemory = console.memory
>   console.memory = "foo"
>   console.memory == originalConsoleMemory
>       => false
> 
> Is it okay?
> 
> I've changed my mind very recently, and think it'd be better to keep the
> original behavior, i.e. ignore any assignments for the time being for the sake
> of compatibility.
> 
> What do you think?

Oops, sorry, you're just ignoring assignments.

lgtm

[jochen (gone - plz use gerrit), 2015-03-25 08:46:39]

With my patch applied, console.memory still triple-equals originalConsoleMemory.

[jochen (gone - plz use gerrit), 2015-03-25 08:46:51]

ok :)

[jochen (gone - plz use gerrit), 2015-03-25 08:46:56]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2015-03-25 08:47:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1033893004/1

[Yuki, 2015-03-25 08:47:19]

https://codereview.chromium.org/1033893004/diff/1/Source/core/timing/ConsoleM...
File Source/core/timing/ConsoleMemory.idl (right):

https://codereview.chromium.org/1033893004/diff/1/Source/core/timing/ConsoleM...
Source/core/timing/ConsoleMemory.idl:8: attribute MemoryInfo memory;
It'd be better to have a comment, why not readonly and assignments to this
attribute are ignored.

[haraken, 2015-03-25 08:47:27]

On 2015/03/25 08:45:06, Yuki wrote:
> On 2015/03/25 08:43:39, Yuki wrote:
> > On 2015/03/25 08:04:28, dcarney wrote:
> > > lgtm
> > 
> > I'm okay with this CL except for one concern.
> > 
> > The new behavior is still different from the old one.
> > 
> > before:
> >   originalConsoleMemory = console.memory
> >   console.memory = "foo"
> >   console.memory == originalConsoleMemory
> >       => true
> > 
> > after:
> >   originalConsoleMemory = console.memory
> >   console.memory = "foo"
> >   console.memory == originalConsoleMemory
> >       => false
> > 
> > Is it okay?
> > 
> > I've changed my mind very recently, and think it'd be better to keep the
> > original behavior, i.e. ignore any assignments for the time being for the
sake
> > of compatibility.
> > 
> > What do you think?
> 
> Oops, sorry, you're just ignoring assignments.
> 
> lgtm

Ah, understood. LGTM.

[jochen (gone - plz use gerrit), 2015-03-25 08:47:49]

The CQ bit was unchecked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-03-25 08:49:14]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-03-25 08:49:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, dcarney@chromium.org, yukishiino@chromium.org
Link to the patchset: https://codereview.chromium.org/1033893004/#ps20001
(title: "updates")

[jochen (gone - plz use gerrit), 2015-03-25 08:49:16]

added a comment

[commit-bot: I haz the power, 2015-03-25 08:49:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1033893004/20001

[commit-bot: I haz the power, 2015-03-25 10:14:31]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192512