Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1033843003: Add NetworkTechnology types to ONC (Closed)

Created:
5 years, 9 months ago by stevenjb
Modified:
5 years, 9 months ago
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add NetworkTechnology types to ONC This also adds the network technology 1x badge to cr_network_icon BUG=470282 Committed: https://crrev.com/634eb9966e649e0bdf79901078befac59a4b937e Cr-Commit-Position: refs/heads/master@{#322409}

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -15 lines) Patch
M chromeos/network/onc/onc_translation_tables.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/network/onc/onc_translation_tables.cc View 1 2 2 chunks +17 lines, -1 line 0 comments Download
M chromeos/network/onc/onc_translator_shill_to_onc.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chromeos/test/data/network/shill_cellular_with_state.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/test/data/network/translation_of_shill_cellular_with_state.onc View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/onc/docs/onc_spec.html View 7 chunks +16 lines, -11 lines 0 comments Download
M components/onc/onc_constants.h View 1 chunk +10 lines, -0 lines 0 comments Download
M components/onc/onc_constants.cc View 1 chunk +10 lines, -0 lines 0 comments Download
A ui/webui/resources/cr_elements/cr_network_icon/badge_1x.png View Binary file 0 comments Download
M ui/webui/resources/cr_elements/cr_network_icon/cr_network_icon.js View 2 chunks +4 lines, -1 line 0 comments Download
M ui/webui/resources/cr_elements/cr_onc/cr_onc_types.js View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/webui/resources/cr_elements_images.grdp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
stevenjb
5 years, 9 months ago (2015-03-24 21:57:47 UTC) #2
michaelpg
ui/ lgtm This badge is... not very pretty :-) Btw, don't we need to support ...
5 years, 9 months ago (2015-03-25 22:34:00 UTC) #3
stevenjb
On 2015/03/25 22:34:00, michaelpg wrote: > ui/ lgtm > > This badge is... not very ...
5 years, 9 months ago (2015-03-25 22:45:42 UTC) #4
pneubeck (no reviews)
ONC changes lgtm
5 years, 9 months ago (2015-03-26 15:59:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033843003/2
5 years, 9 months ago (2015-03-26 16:03:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/36929) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-03-26 16:07:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033843003/30001
5 years, 9 months ago (2015-03-26 16:16:12 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:30001)
5 years, 9 months ago (2015-03-26 17:23:23 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 17:24:09 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/634eb9966e649e0bdf79901078befac59a4b937e
Cr-Commit-Position: refs/heads/master@{#322409}

Powered by Google App Engine
This is Rietveld 408576698