Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1889)

Unified Diff: tests/PDFPrimitivesTest.cpp

Issue 1033833002: SkPDF: unit test cleanup (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/PDFPrimitivesTest.cpp
diff --git a/tests/PDFPrimitivesTest.cpp b/tests/PDFPrimitivesTest.cpp
index 7861ef0fe145dc7e7359ce5d4361150283fa8aec..189808fdfa5661de4e9dbe735a13ac3c286f4260 100644
--- a/tests/PDFPrimitivesTest.cpp
+++ b/tests/PDFPrimitivesTest.cpp
@@ -23,24 +23,6 @@
#include "SkTypes.h"
#include "Test.h"
-class SkPDFTestDict : public SkPDFDict {
-public:
- virtual void getResources(const SkTSet<SkPDFObject*>& knownResourceObjects,
- SkTSet<SkPDFObject*>* newResourceObjects) {
- for (int i = 0; i < fResources.count(); i++) {
- newResourceObjects->add(fResources[i]);
- fResources[i]->ref();
- }
- }
-
- void addResource(SkPDFObject* object) {
- fResources.append(1, &object);
- }
-
-private:
- SkTDArray<SkPDFObject*> fResources;
-};
-
#define DUMMY_TEXT "DCT compessed stream."
static bool stream_equals(const SkDynamicMemoryWStream& stream, size_t offset,
@@ -197,8 +179,8 @@ static void TestObjectRef(skiatest::Reporter* reporter) {
}
static void TestSubstitute(skiatest::Reporter* reporter) {
- SkAutoTUnref<SkPDFTestDict> proxy(new SkPDFTestDict());
- SkAutoTUnref<SkPDFTestDict> stub(new SkPDFTestDict());
+ SkAutoTUnref<SkPDFDict> proxy(new SkPDFDict());
+ SkAutoTUnref<SkPDFDict> stub(new SkPDFDict());
proxy->insert("Value", new SkPDFInt(33))->unref();
stub->insert("Value", new SkPDFInt(44))->unref();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698