Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: commit-queue/verification/try_job_on_rietveld.py

Issue 103383002: CQ: Remove one out of two usages of buildbot_json in try_job_on_rietveld.py (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: commit-queue/verification/try_job_on_rietveld.py
===================================================================
--- commit-queue/verification/try_job_on_rietveld.py (revision 238151)
+++ commit-queue/verification/try_job_on_rietveld.py (working copy)
@@ -667,16 +667,14 @@
self.try_server_url, job.builder, job.build)
@model.immutable
- def _update_dashboard(self, pending, job, status):
+ def _update_dashboard(self, pending, job):
"""Updates the CQ dashboard with the current Try Job state as known to the
CQ.
"""
logging.debug('_update_dashboard(%s/%s)', job.builder, job.build)
- build = status.builders[job.builder].builds[job.build]
info = {
'build': job.build,
'builder': job.builder,
- 'duration': build.duration,
'job_name': 'CQ',
'result': job.result,
'revision': job.revision,
@@ -742,7 +740,7 @@
if handle:
for updated_key in keys:
job = jobs.try_jobs[updated_key]
- self._update_dashboard(pending, job, status)
+ self._update_dashboard(pending, job)
jobs.signal_as_failed_if_needed(job, self._build_status_url(job), now)
return True
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698