Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1033813002: Update Media Router WebUI Icons. (Closed)

Created:
5 years, 9 months ago by apacible
Modified:
5 years, 8 months ago
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Media Router WebUI Icons. Some icons are similar but not exactly what we had previously. Added 2X versions of the downward arrow (default and hover) as well as the sad face icon. BUG=464222 Committed: https://crrev.com/e156661a7dd822a182a805d0d94af00d70984e5a Cr-Commit-Position: refs/heads/master@{#322814}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/media_router/elements/icon/chromecast-icon.png View Binary file 0 comments Download
M chrome/browser/resources/media_router/elements/icon/chromecast-icon2x.png View Binary file 0 comments Download
M chrome/browser/resources/media_router/elements/icon/close-gray.png View Binary file 0 comments Download
M chrome/browser/resources/media_router/elements/icon/close-gray2x.png View Binary file 0 comments Download
M chrome/browser/resources/media_router/elements/icon/down-arrow.png View Binary file 0 comments Download
M chrome/browser/resources/media_router/elements/icon/down-arrow-hover.png View Binary file 0 comments Download
A chrome/browser/resources/media_router/elements/icon/down-arrow-hover2x.png View Binary file 0 comments Download
A chrome/browser/resources/media_router/elements/icon/down-arrow2x.png View Binary file 0 comments Download
M chrome/browser/resources/media_router/elements/icon/generic-device.png View Binary file 0 comments Download
M chrome/browser/resources/media_router/elements/icon/generic-device2x.png View Binary file 0 comments Download
M chrome/browser/resources/media_router/elements/icon/hangouts-icon.png View Binary file 0 comments Download
M chrome/browser/resources/media_router/elements/icon/hangouts-icon2x.png View Binary file 0 comments Download
M chrome/browser/resources/media_router/elements/icon/sad-face.png View Binary file 0 comments Download
A chrome/browser/resources/media_router/elements/icon/sad-face2x.png View Binary file 0 comments Download

Messages

Total messages: 10 (3 generated)
apacible
PTAL, thanks! Icons proposed by UX, OK'd by PM. One down arrow icon (showing) will ...
5 years, 9 months ago (2015-03-24 21:08:43 UTC) #2
mark a. foltz
lgtm
5 years, 9 months ago (2015-03-24 22:54:47 UTC) #3
apacible
ping jhawkins for browser_resources.grd Down arrow icon (showing) will be updated in a future CL.
5 years, 9 months ago (2015-03-25 20:59:15 UTC) #4
James Hawkins
lgtm
5 years, 8 months ago (2015-03-30 17:00:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033813002/1
5 years, 8 months ago (2015-03-30 17:06:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-30 18:23:32 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 18:24:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e156661a7dd822a182a805d0d94af00d70984e5a
Cr-Commit-Position: refs/heads/master@{#322814}

Powered by Google App Engine
This is Rietveld 408576698