X87: VectorICs: keyed element loads were kicking out non-smi keys unnecessarily

X87: VectorICs: keyed element loads were kicking out non-smi keys unnecessarily

port 6689cc27ebe60685c025de9ae1f09919093f8213 (r27377)

original commit message:

    Handlers should be in charge of this work. The change uncovered a bug in
    vector-ics related to keyed loads into strings. It's important for
    StringCharCodeAtGenerator, a helper used in full code and in
    LoadIndexedStringStub (a handler) to protect the vector and slot registers
    when it makes a runtime call to convert a HeapNumber to a Smi.

    It's still possible for the handler to MISS after this call, perhaps due
    to out of bounds access. In that case, the vector and slot registers need
    to be delivered safely to the MISS handler.

BUG=

Committed: https://crrev.com/5d5bf2b77f41ab09b5ad97e460a034cf718580e7
Cr-Commit-Position: refs/heads/master@{#27461}

[chunyang.dai, 2015-03-25 07:28:04]

chunyang.dai@intel.com changed reviewers:
+ weiliang.lin@intel.com

[chunyang.dai, 2015-03-25 07:28:04]

PTAL.

[Weiliang, 2015-03-26 01:35:46]

The CQ bit was checked by weiliang.lin@intel.com

[Weiliang, 2015-03-26 01:35:46]

lgtm

[commit-bot: I haz the power, 2015-03-26 01:36:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1033733005/1

[commit-bot: I haz the power, 2015-03-26 02:53:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-26 02:53:22]

Patchset 1 (id:??) landed as
https://crrev.com/5d5bf2b77f41ab09b5ad97e460a034cf718580e7
Cr-Commit-Position: refs/heads/master@{#27461}