Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: test/mjsunit/fast-prototype.js

Issue 1033653002: Move prototype metadata from internal properties to prototype maps (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: small fixes Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/transitions.cc ('k') | test/mjsunit/regress/regress-put-prototype-transition.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/fast-prototype.js
diff --git a/test/mjsunit/fast-prototype.js b/test/mjsunit/fast-prototype.js
index c59ec94ef0cffb30b661975d9dd76fc99cafcde6..2fb476ccb1645103a21e5dc2912c8aa3ef04ac9f 100644
--- a/test/mjsunit/fast-prototype.js
+++ b/test/mjsunit/fast-prototype.js
@@ -56,7 +56,7 @@ function DoProtoMagic(proto, set__proto__) {
}
-function test(use_new, add_first, set__proto__, same_map_as) {
+function test(use_new, add_first, set__proto__) {
var proto = use_new ? new Super() : {};
// New object is fast.
@@ -74,16 +74,8 @@ function test(use_new, add_first, set__proto__, same_map_as) {
// Still fast
assertTrue(%HasFastProperties(proto));
AddProps(proto);
- if (set__proto__) {
- // After we add all those properties it went slow mode again :-(
- assertFalse(%HasFastProperties(proto));
- } else {
- // .prototype keeps it fast.
- assertTrue(%HasFastProperties(proto));
- }
- }
- if (same_map_as && !add_first && set__proto__) {
- assertTrue(%HaveSameMap(same_map_as, proto));
+ // Still fast.
+ assertTrue(%HasFastProperties(proto));
}
return proto;
}
@@ -96,9 +88,7 @@ for (var i = 0; i < 4; i++) {
var use_new = ((i & 2) != 0);
test(use_new, true, set__proto__);
-
- var last = test(use_new, false, set__proto__);
- test(use_new, false, set__proto__, last);
+ test(use_new, false, set__proto__);
}
« no previous file with comments | « src/transitions.cc ('k') | test/mjsunit/regress/regress-put-prototype-transition.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698