Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1033643002: X87: [es6] generate rest parameters correctly for subclass constructors (Closed)

Created:
5 years, 9 months ago by chunyang.dai
Modified:
5 years, 9 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [es6] generate rest parameters correctly for subclass constructors port bef80fcfd7e89cadc215f7d10a016a375e346490 (r27344) original commit message: [es6] generate rest parameters correctly for subclass constructors BUG= Committed: https://crrev.com/ebae8c145c808c55786eeff202a457452aaa5d7d Cr-Commit-Position: refs/heads/master@{#27459}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M src/x87/full-codegen-x87.cc View 3 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 9 months ago (2015-03-24 15:12:48 UTC) #2
Weiliang
lgtm
5 years, 9 months ago (2015-03-26 01:35:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033643002/1
5 years, 9 months ago (2015-03-26 01:35:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 02:11:20 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 02:12:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ebae8c145c808c55786eeff202a457452aaa5d7d
Cr-Commit-Position: refs/heads/master@{#27459}

Powered by Google App Engine
This is Rietveld 408576698