Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1033623002: Revert of [es6] Object.getPrototypeOf should work with values (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
CC:
v8-dev, caitp (gmail)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es6] Object.getPrototypeOf should work with values (patchset #3 id:40001 of https://codereview.chromium.org/1014813003/) Reason for revert: Layout test failures. Please update layout test expectations before landing this, in order to not block the roll. Original issue's description: > [es6] Object.getPrototypeOf should work with values > > The final spec for Object.getPrototypeOf calls ToObject on the > parameter, which means that it should only throw for null and > undefined. For other non object values the prototype of the wrapper > should be used. > > BUG=v8:3964 > LOG=N > R=adamk, rossberg@chromium.org > > Committed: https://crrev.com/ea463a916bbe5994b0d2d04e8075058b373b2e2c > Cr-Commit-Position: refs/heads/master@{#27354} TBR=adamk@chromium.org,rossberg@chromium.org,arv@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3964 Committed: https://crrev.com/992751d0dc5be63845a371cb9fb2c1313efb3bdf Cr-Commit-Position: refs/heads/master@{#27389}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -86 lines) Patch
M src/v8natives.js View 1 chunk +5 lines, -2 lines 0 comments Download
M test/mjsunit/get-prototype-of.js View 1 chunk +33 lines, -67 lines 0 comments Download
M test/mjsunit/harmony/set-prototype-of.js View 1 chunk +8 lines, -2 lines 0 comments Download
M test/test262-es6/test262-es6.status View 1 chunk +0 lines, -5 lines 0 comments Download
M test/test262/test262.status View 2 chunks +0 lines, -6 lines 0 comments Download
M test/webkit/prototypes.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/webkit/prototypes-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Created Revert of [es6] Object.getPrototypeOf should work with values
5 years, 9 months ago (2015-03-24 09:18:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033623002/1
5 years, 9 months ago (2015-03-24 09:18:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 09:19:14 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 09:19:34 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/992751d0dc5be63845a371cb9fb2c1313efb3bdf
Cr-Commit-Position: refs/heads/master@{#27389}

Powered by Google App Engine
This is Rietveld 408576698