LayoutTests/fast/canvas/webgl/context-gc-custom-properties.html - Issue 1033613002: Mark wrappers of canvas rendering context objects as dependent.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/canvas/webgl/context-gc-custom-properties.html

Issue 1033613002: Mark wrappers of canvas rendering context objects as dependent. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: update test expectation Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/canvas/canvas-context-gc-custom-properties-expected.txt ('k') | LayoutTests/fast/canvas/webgl/context-gc-custom-properties-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../../../resources/js-test.js"></script>

	4 <script src="resources/webgl-test.js"></script>

	5 </head>

	6 <body>

	7 <script>

	8 description("Verify that the custom properties on a WebGL rendering context obje ct are retained across GCs.");

	9

	10 window.jsTestIsAsync = true;

	11

	12 if (window.testRunner) {

	13 testRunner.dumpAsText();

	14 testRunner.waitUntilDone();

	15 }

	16

	17 function runTest() {

	18 canvas = document.createElement("canvas");

	19 context = create3DContext(canvas);

	20 context.customProperty = "value";

	21 shouldBeEqualToString("context.customProperty", "value");

	22 context = null;

	23 gc();
	Justin Novosad 2015/03/24 16:08:32 Just a suggestion, but you could go a step further Just a suggestion, but you could go a step further here and set canvas to null before gc(), and the re-get the canvas from the document. sof 2015/03/24 16:14:23 i.e., not use document.createElement()? Show quoted text On 2015/03/24 16:08:32, junov wrote: > Just a suggestion, but you could go a step further here and set canvas to null > before gc(), and the re-get the canvas from the document. i.e., not use document.createElement()?
	24 context = create3DContext(canvas);

	25 shouldBeEqualToString("context.customProperty", "value");

	26 finishJSTest();

	27 }

	28

	29 window.onload = runTest;

	30 </script>

	31 </body>

	32 </html>

OLD	NEW