Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1033613002: Mark wrappers of canvas rendering context objects as dependent. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, arv+blink, vivekg_samsung, dshwang, Justin Novosad, vivekg, dglazkov+blink, Rik, Inactive, aandrey+blink_chromium.org, blink-reviews-bindings_chromium.org, bajones
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Mark wrappers of canvas rendering context objects as dependent. When initially called, canvas.getContext() will return a fresh rendering context object, but at the same time switch its "context mode" to a direct one (2d or webgl), such that subsequent getContext() with the same contextID argument will return that initially created context object. To correctly provide that same-object identity, the wrapper object must be marked as depending on the canvas element object, such that it will be retained across GCs. R=junov,haraken BUG=450410 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192465

Patch Set 1 #

Patch Set 2 : update test expectation #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -1 line) Patch
A LayoutTests/fast/canvas/canvas-context-gc-custom-properties.html View 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/fast/canvas/canvas-context-gc-custom-properties-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/fast/canvas/webgl/context-gc-custom-properties.html View 1 chunk +32 lines, -0 lines 2 comments Download
A LayoutTests/fast/canvas/webgl/context-gc-custom-properties-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/gc-9-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/WebGL2RenderingContext.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
sof
please take a look.
5 years, 9 months ago (2015-03-24 10:17:36 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-24 10:33:17 UTC) #3
Justin Novosad
lgtm with suggestion https://codereview.chromium.org/1033613002/diff/20001/LayoutTests/fast/canvas/webgl/context-gc-custom-properties.html File LayoutTests/fast/canvas/webgl/context-gc-custom-properties.html (right): https://codereview.chromium.org/1033613002/diff/20001/LayoutTests/fast/canvas/webgl/context-gc-custom-properties.html#newcode23 LayoutTests/fast/canvas/webgl/context-gc-custom-properties.html:23: gc(); Just a suggestion, but you ...
5 years, 9 months ago (2015-03-24 16:08:32 UTC) #4
sof
https://codereview.chromium.org/1033613002/diff/20001/LayoutTests/fast/canvas/webgl/context-gc-custom-properties.html File LayoutTests/fast/canvas/webgl/context-gc-custom-properties.html (right): https://codereview.chromium.org/1033613002/diff/20001/LayoutTests/fast/canvas/webgl/context-gc-custom-properties.html#newcode23 LayoutTests/fast/canvas/webgl/context-gc-custom-properties.html:23: gc(); On 2015/03/24 16:08:32, junov wrote: > Just a ...
5 years, 9 months ago (2015-03-24 16:14:23 UTC) #5
sof
On 2015/03/24 16:14:23, sof wrote: > https://codereview.chromium.org/1033613002/diff/20001/LayoutTests/fast/canvas/webgl/context-gc-custom-properties.html > File LayoutTests/fast/canvas/webgl/context-gc-custom-properties.html (right): > > https://codereview.chromium.org/1033613002/diff/20001/LayoutTests/fast/canvas/webgl/context-gc-custom-properties.html#newcode23 > ...
5 years, 9 months ago (2015-03-24 16:31:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033613002/20001
5 years, 9 months ago (2015-03-24 19:08:09 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=192465
5 years, 9 months ago (2015-03-24 19:52:11 UTC) #9
Ken Russell (switch to Gerrit)
5 years, 9 months ago (2015-03-24 22:02:10 UTC) #10
Message was sent while issue was closed.
Thanks for this fix!

Powered by Google App Engine
This is Rietveld 408576698