Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Unified Diff: public/web/WebPlugin.h

Issue 1033603007: Blink: Pass 'unobscured' rect to WebPlugins. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/tests/FakeWebPlugin.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebPlugin.h
diff --git a/public/web/WebPlugin.h b/public/web/WebPlugin.h
index 6b84860c21f2aa8de5ee6c1823fc30085a5bc02c..d9423e375dc84738edf704dba82d23330125984e 100644
--- a/public/web/WebPlugin.h
+++ b/public/web/WebPlugin.h
@@ -89,10 +89,19 @@ public:
virtual void paint(WebCanvas*, const WebRect&) = 0;
+ // DEPRECATED. TODO(tommycli): Remove once embedders migrate to the new interface.
+ virtual void updateGeometry(
+ const WebRect& windowRect, const WebRect& clipRect,
+ const WebVector<WebRect>& cutOutsRects, bool isVisible) { }
+
// Coordinates are relative to the containing window.
virtual void updateGeometry(
- const WebRect& frameRect, const WebRect& clipRect,
- const WebVector<WebRect>& cutOutsRects, bool isVisible) = 0;
+ const WebRect& windowRect, const WebRect& clipRect,
+ const WebRect& unobscuredRect, const WebVector<WebRect>& cutOutsRects,
+ bool isVisible) {
+ // TODO(tommycli): This default implementation calls the old, deprecated interface. This method should be pure virtual after the deprecated interface is removed.
+ updateGeometry(windowRect, clipRect, cutOutsRects, isVisible);
+ }
virtual void updateFocus(bool focused, WebFocusType) = 0;
« no previous file with comments | « Source/web/tests/FakeWebPlugin.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698