Blink: Pass 'unobscured' rect to WebPlugins.

public/web/WebPlugin.h

 /*
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2014 Opera Software ASA. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 73 matching lines @@
     // Returns true if this plugin supports input method, which implements
     // setComposition() and confirmComposition() below.
     virtual bool supportsInputMethod() const { return false; }
 
     virtual bool canProcessDrag() const { return false; }
 
     virtual void paint(WebCanvas*, const WebRect&) = 0;
 
     // Coordinates are relative to the containing window.
     virtual void updateGeometry(
-        const WebRect& frameRect, const WebRect& clipRect,
-        const WebVector<WebRect>& cutOutsRects, bool isVisible) = 0;
+        const WebRect& windowRect, const WebRect& clipRect,
+        const WebRect& unobscuredRect, const WebVector<WebRect>& cutOutsRects,
+        bool isVisible) = 0;

[piman, 2015/03/24 23:59:21]

You'll need to stage this change, e.g. by first providing both (old and new)
implementations on the Chrome side, then land this, wait for it to roll, then
remove the old implementations.

[tommycli, 2015/03/25 20:18:35]

Done. I staged this by:

a) Adding both versions to the WebPlugin interface and calling both.
b) In separate patch: Modifying chrome/ to migrate all implementing classes to
the new version.
c) In separate Blink patch: Remove deprecated updateGeometry call.

 
     virtual void updateFocus(bool focused, WebFocusType) = 0;
 
     virtual void updateVisibility(bool) = 0;
 
     virtual bool acceptsInputEvents() = 0;
     virtual bool handleInputEvent(const WebInputEvent&, WebCursorInfo&) = 0;
 
     virtual bool handleDragStatusUpdate(WebDragStatus, const WebDragData&, WebDragOperationsMask, const WebPoint& position, const WebPoint& screenPosition) { return false; }
 
@@ skipping 74 matching lines @@
     virtual bool isPlaceholder() { return true; }
     virtual bool shouldPersist() const { return false; }
 
 protected:
     ~WebPlugin() { }
 };
 
 } // namespace blink
 
 #endif