Blink: Pass 'unobscured' rect to WebPlugins.

Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 2184 matching lines @@
 
     // FIXME: childrenClipRect relies on compositingState, which is not necessarily up to date.
     // https://code.google.com/p/chromium/issues/detail?id=343769
     DisableCompositingQueryAsserts disabler;
 
     // Apply the clip from the layer.
     IntRect clipRect = contentsToRootFrame(pixelSnappedIntRect(enclosingLayer->clipper().childrenClipRect()));
     return intersection(clipRect, windowClipRect());
 }
 
+IntRect FrameView::unobscuredRectForFrameOwner(const HTMLFrameOwnerElement* ownerElement) const

[Julien - ping for review, 2015/03/26 20:41:51]

This looks awfully close to windowClipRectForFrameOwner, can't we share code
with it instead of completely duplicating code?

[tommycli, 2015/03/27 19:39:00]

Done.

+{
+    if (!ownerElement->layoutObject())
+        return IntRect();
+
+    const DeprecatedPaintLayer* enclosingLayer = ownerElement->layoutObject()->enclosingLayer();
+    if (!enclosingLayer)
+        return IntRect();
+
+    // FIXME: childrenClipRect relies on compositingState, which is not necessarily up to date.
+    // https://code.google.com/p/chromium/issues/detail?id=343769
+    DisableCompositingQueryAsserts disabler;

[Julien - ping for review, 2015/03/26 20:41:51]

We shouldn't be adding more of these :(

[tommycli, 2015/03/27 19:39:00]

Done.

+
+    // Apply the clip from the layer.
+    IntRect clipRect = contentsToRootFrame(pixelSnappedIntRect(enclosingLayer->clipper().childrenClipRect()));
+
+    // If element is not in root frame, clip to the local frame.
+    // FIXME: Do we need to do this for remote frames?
+    if (m_frame->deprecatedLocalOwner())
+        clipRect.intersect(contentsToRootFrame(visibleContentRect()));
+
+    return clipRect;
+}
+
 bool FrameView::shouldUseIntegerScrollOffset() const
 {
     if (m_frame->settings() && !m_frame->settings()->preferCompositingToLCDTextEnabled())
         return true;
     return false;
 }
 
 bool FrameView::isActive() const
 {
     Page* page = frame().page();
@@ skipping 1852 matching lines @@
 {
     Settings* settings = frame().settings();
     if (!settings || !settings->rootLayerScrolls())
         return this;
 
     LayoutView* layoutView = this->layoutView();
     return layoutView ? layoutView->scrollableArea() : nullptr;
 }
 
 } // namespace blink