Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 1033603002: Web MIDI: loop style change to be robust (Closed)

Created:
5 years, 9 months ago by Takashi Toyoshima
Modified:
5 years, 9 months ago
Reviewers:
yhirano
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI: loop style change to be robust Potentially, client callbacks invoked inside the loop may touch the container indirectly. This patch takes such cases just in case. BUG=469416 TEST=LayoutTests/webmidi Committed: https://crrev.com/e841a2aeca894ef5b8cc8b0537cd4dd07c266e5e Cr-Commit-Position: refs/heads/master@{#321982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M content/renderer/media/midi_message_filter.h View 1 chunk +5 lines, -1 line 0 comments Download
M content/renderer/media/midi_message_filter.cc View 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Takashi Toyoshima
ptal
5 years, 9 months ago (2015-03-24 07:39:09 UTC) #2
yhirano
lgtm
5 years, 9 months ago (2015-03-24 08:59:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033603002/1
5 years, 9 months ago (2015-03-24 12:52:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 12:56:54 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 12:57:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e841a2aeca894ef5b8cc8b0537cd4dd07c266e5e
Cr-Commit-Position: refs/heads/master@{#321982}

Powered by Google App Engine
This is Rietveld 408576698