Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1033583002: correct reporting of kAlphaUnchanged_Flag in ModeFilter (Closed)

Created:
5 years, 9 months ago by reed2
Modified:
5 years, 9 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

correct reporting of kAlphaUnchanged_Flag in ModeFilter BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/afced66b508ac4cd3616e2f707db27b7d6f670e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M src/effects/SkColorFilters.cpp View 3 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033583002/1
5 years, 9 months ago (2015-03-24 03:00:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/afced66b508ac4cd3616e2f707db27b7d6f670e1
5 years, 9 months ago (2015-03-24 03:05:09 UTC) #3
reed2
5 years, 9 months ago (2015-03-24 10:48:12 UTC) #4
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1026313002/ by reed@chromium.org.

The reason for reverting is: reverting experiment. need to rebaseilne layouttest

svg/css/text-gradient-shadow.svg.

Powered by Google App Engine
This is Rietveld 408576698