Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 1033573003: Memory sheriffing: (Closed)

Created:
5 years, 9 months ago by Alexander Potapenko
Modified:
5 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Memory sheriffing: - suppress a NULL deref in blink::FocusController::focusedOrMainFrame() (issue 470055) - extend the suppression for leaks from content::ServiceRegistryImpl::Bind (issue 455732) BUG=470055, 455732 TBR=thakis@chromium.org NOTRY=true Committed: https://crrev.com/9552587a0486d40fd7a56db516ea307632c0086e Cr-Commit-Position: refs/heads/master@{#321980}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M tools/valgrind/drmemory/suppressions_full.txt View 1 chunk +7 lines, -0 lines 1 comment Download
M tools/valgrind/memcheck/suppressions.txt View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Alexander Potapenko
TBR
5 years, 9 months ago (2015-03-24 12:36:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033573003/1
5 years, 9 months ago (2015-03-24 12:37:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 12:37:42 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9552587a0486d40fd7a56db516ea307632c0086e Cr-Commit-Position: refs/heads/master@{#321980}
5 years, 9 months ago (2015-03-24 12:38:38 UTC) #5
Nico
5 years, 9 months ago (2015-03-24 15:34:20 UTC) #6
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/1033573003/diff/1/tools/valgrind/drmemory/sup...
File tools/valgrind/drmemory/suppressions_full.txt (right):

https://codereview.chromium.org/1033573003/diff/1/tools/valgrind/drmemory/sup...
tools/valgrind/drmemory/suppressions_full.txt:1924:
content.dll!content::RenderWidget::willBeginCompositorFrame
shouldn't this one lead to a revert upstream too?

Powered by Google App Engine
This is Rietveld 408576698