cc: Various code safety improvements in video compositing code.

cc/layers/video_layer_impl.h

Index: cc/layers/video_layer_impl.h
diff --git a/cc/layers/video_layer_impl.h b/cc/layers/video_layer_impl.h
index d05bd5768e62f57c6d2773880397df7c671ef68b..dc329590440fc43a4e836de5c2dd664ae0288928 100644
--- a/cc/layers/video_layer_impl.h
+++ b/cc/layers/video_layer_impl.h
@@ -18,11 +18,14 @@ class VideoFrame;
 }
 
 namespace cc {
+

[danakj, 2015/03/24 17:38:01]

why the whitespace change?

[sunnyps, 2015/03/24 19:43:38]

Done.

 class VideoFrameProvider;
 class VideoFrameProviderClientImpl;
 
 class CC_EXPORT VideoLayerImpl : public LayerImpl {
  public:
+  // Must be called on the impl thread while the main thread is blocked. This is
+  // so that |provider| stays alive while this is being created.
   static scoped_ptr<VideoLayerImpl> Create(LayerTreeImpl* tree_impl,
                                            int id,
                                            VideoFrameProvider* provider,
@@ -31,7 +34,6 @@ class CC_EXPORT VideoLayerImpl : public LayerImpl {
 
   // LayerImpl implementation.
   scoped_ptr<LayerImpl> CreateLayerImpl(LayerTreeImpl* tree_impl) override;
-  void PushPropertiesTo(LayerImpl* layer) override;
   bool WillDraw(DrawMode draw_mode,
                 ResourceProvider* resource_provider) override;
   void AppendQuads(RenderPass* render_pass,
@@ -40,17 +42,15 @@ class CC_EXPORT VideoLayerImpl : public LayerImpl {
   void DidBecomeActive() override;
   void ReleaseResources() override;
 
-  void SetNeedsRedraw();
-
-  void SetProviderClientImpl(
-      scoped_refptr<VideoFrameProviderClientImpl> provider_client_impl);
-
   media::VideoRotation video_rotation() const { return video_rotation_; }

[danakj, 2015/03/24 17:38:01]

why is this moving?

[sunnyps, 2015/03/24 19:43:38]

Done.

+  void SetNeedsRedraw();
 
  private:
-  VideoLayerImpl(LayerTreeImpl* tree_impl,
-                 int id,
-                 media::VideoRotation video_rotation);
+  VideoLayerImpl(
+      LayerTreeImpl* tree_impl,
+      int id,
+      scoped_refptr<VideoFrameProviderClientImpl> provider_client_impl,
+      media::VideoRotation video_rotation);
 
   const char* LayerTypeAsString() const override;