Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1033553004: Files.app: Update shared status of icons on grid items. (Closed)

Created:
5 years, 9 months ago by fukino
Modified:
5 years, 9 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Update shared status of icons on grid items. When grid item is created or metadata is updated, shared status of placeholder was updated, but the icon on the bottom was not updated. By this CL, updateSharedStatus() updates both. BUG=469963 TEST=manual test Committed: https://crrev.com/4721fe97dc6683f81347bd74efb4d98c8fbdb9c5 Cr-Commit-Position: refs/heads/master@{#321953}

Patch Set 1 #

Patch Set 2 : Changed the function name to make it private. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M ui/file_manager/file_manager/foreground/js/ui/file_grid.js View 1 5 chunks +23 lines, -10 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
fukino
Could you take a look? Thanks! https://codereview.chromium.org/1033553004/diff/20001/ui/file_manager/file_manager/foreground/js/ui/file_grid.js File ui/file_manager/file_manager/foreground/js/ui/file_grid.js (left): https://codereview.chromium.org/1033553004/diff/20001/ui/file_manager/file_manager/foreground/js/ui/file_grid.js#oldcode229 ui/file_manager/file_manager/foreground/js/ui/file_grid.js:229: * @param {function(HTMLImageElement)=} ...
5 years, 9 months ago (2015-03-24 06:09:00 UTC) #2
yawano
lgtm. Thank you!
5 years, 9 months ago (2015-03-24 07:02:20 UTC) #3
fukino
On 2015/03/24 07:02:20, yawano wrote: > lgtm. Thank you! Thanks!
5 years, 9 months ago (2015-03-24 07:47:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033553004/20001
5 years, 9 months ago (2015-03-24 07:47:37 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-24 08:24:13 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 08:24:52 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4721fe97dc6683f81347bd74efb4d98c8fbdb9c5
Cr-Commit-Position: refs/heads/master@{#321953}

Powered by Google App Engine
This is Rietveld 408576698