Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 1033553003: content: Re-enable ChildDiscardableSharedMemoryManagerBrowserTest.LockMemory test. (Closed)

Created:
5 years, 9 months ago by reveman
Modified:
5 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Re-enable ChildDiscardableSharedMemoryManagerBrowserTest.LockMemory test. BUG= TEST=content_browsertests --gtest_filter=ChildDiscardableSharedMemoryManagerBrowserTest.LockMemory Committed: https://crrev.com/98e563846f88a2df7107e170381a6a5e8bd4454b Cr-Commit-Position: refs/heads/master@{#322122}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/child/child_discardable_shared_memory_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
reveman
I'd like to try and re-enable these tests, one at a time. This is the ...
5 years, 9 months ago (2015-03-24 22:26:33 UTC) #2
Avi (use Gerrit)
lgtm Good luck.
5 years, 9 months ago (2015-03-25 03:01:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033553003/1
5 years, 9 months ago (2015-03-25 03:15:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 06:35:45 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/98e563846f88a2df7107e170381a6a5e8bd4454b Cr-Commit-Position: refs/heads/master@{#322122}
5 years, 9 months ago (2015-03-25 06:36:33 UTC) #7
reveman
5 years, 9 months ago (2015-03-25 16:50:59 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1038703002/ by reveman@chromium.org.

The reason for reverting is: Still flaky.

Powered by Google App Engine
This is Rietveld 408576698