Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: tests/PDFPrimitivesTest.cpp

Issue 1033543002: SKPDF: refactor pdfcatalog and pdfdocument (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: 2015-03-23 (Monday) 19:02:27 EDT Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/pdf/SkPDFCatalog.cpp ('K') | « src/pdf/SkPDFTypes.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/PDFPrimitivesTest.cpp
diff --git a/tests/PDFPrimitivesTest.cpp b/tests/PDFPrimitivesTest.cpp
index 7861ef0fe145dc7e7359ce5d4361150283fa8aec..7c1f19daf4fa0e1c98ce87adf8a5fb8331f982bd 100644
--- a/tests/PDFPrimitivesTest.cpp
+++ b/tests/PDFPrimitivesTest.cpp
@@ -95,7 +95,7 @@ static void CheckObjectOutput(skiatest::Reporter* reporter, SkPDFObject* obj,
static char footer[] = "\nendobj\n";
static size_t footerLen = strlen(footer);
- catalog.addObject(obj, false);
+ catalog.addObject(obj);
size_t indirectSize = get_output_size(obj, &catalog, true);
REPORTER_ASSERT(reporter,
@@ -167,9 +167,9 @@ static void TestCatalog(skiatest::Reporter* reporter) {
int1.get()->ref();
SkAutoTUnref<SkPDFInt> int1Again(int1.get());
- catalog.addObject(int1.get(), false);
- catalog.addObject(int2.get(), false);
- catalog.addObject(int3.get(), false);
+ catalog.addObject(int1.get());
+ catalog.addObject(int2.get());
+ catalog.addObject(int3.get());
REPORTER_ASSERT(reporter, catalog.getObjectNumber(int1.get()) == 1);
REPORTER_ASSERT(reporter, catalog.getObjectNumber(int2.get()) == 2);
@@ -183,8 +183,8 @@ static void TestObjectRef(skiatest::Reporter* reporter) {
SkAutoTUnref<SkPDFObjRef> int2ref(new SkPDFObjRef(int2.get()));
SkPDFCatalog catalog;
- catalog.addObject(int1.get(), false);
- catalog.addObject(int2.get(), false);
+ catalog.addObject(int1.get());
+ catalog.addObject(int2.get());
REPORTER_ASSERT(reporter, catalog.getObjectNumber(int1.get()) == 1);
REPORTER_ASSERT(reporter, catalog.getObjectNumber(int2.get()) == 2);
@@ -204,7 +204,7 @@ static void TestSubstitute(skiatest::Reporter* reporter) {
stub->insert("Value", new SkPDFInt(44))->unref();
SkPDFCatalog catalog;
- catalog.addObject(proxy.get(), false);
+ catalog.addObject(proxy.get());
catalog.setSubstitute(proxy.get(), stub.get());
REPORTER_ASSERT(reporter, stub.get() == catalog.getSubstituteObject(proxy));
« src/pdf/SkPDFCatalog.cpp ('K') | « src/pdf/SkPDFTypes.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698