Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1033513003: Cleans up events to just the parts we're actually using (Closed)

Created:
5 years, 9 months ago by sky
Modified:
5 years, 9 months ago
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Cleans up events to just the parts we're actually using Also unifies mouse and touch into a single event type. R=abarth@chromium.org, erg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b5698886ded259610f083ae1f5339102d92ff857

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -475 lines) Patch
M examples/embedded_app/embedded_app.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M examples/nesting_app/nesting_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/pdf_viewer/pdf_viewer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M examples/spinning_cube/gles2_client_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/spinning_cube/gles2_client_impl.cc View 1 2 chunks +34 lines, -30 lines 0 comments Download
M examples/spinning_cube/spinning_cube_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/wm_flow/app/app.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/wm_flow/wm/wm.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/input_events/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
D mojo/converters/input_events/input_event_names.h View 1 chunk +0 lines, -46 lines 0 comments Download
M mojo/converters/input_events/input_events_type_converters.h View 1 chunk +2 lines, -5 lines 0 comments Download
M mojo/converters/input_events/input_events_type_converters.cc View 1 7 chunks +151 lines, -138 lines 0 comments Download
M mojo/services/input_events/public/interfaces/input_event_constants.mojom View 2 chunks +10 lines, -41 lines 0 comments Download
M mojo/services/input_events/public/interfaces/input_events.mojom View 2 chunks +13 lines, -40 lines 0 comments Download
M services/native_viewport/native_viewport_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/native_viewport/native_viewport_impl.cc View 2 chunks +6 lines, -23 lines 0 comments Download
M services/native_viewport/platform_viewport.h View 4 chunks +2 lines, -8 lines 0 comments Download
M services/native_viewport/platform_viewport_android.h View 1 chunk +0 lines, -2 lines 0 comments Download
M services/native_viewport/platform_viewport_android.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M services/native_viewport/platform_viewport_headless.h View 1 chunk +0 lines, -2 lines 0 comments Download
M services/native_viewport/platform_viewport_headless.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M services/native_viewport/platform_viewport_x11.cc View 5 chunks +39 lines, -6 lines 0 comments Download
M sky/viewer/converters/input_event_types.h View 1 chunk +7 lines, -0 lines 0 comments Download
M sky/viewer/converters/input_event_types.cc View 6 chunks +72 lines, -99 lines 0 comments Download
M sky/viewer/document_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
5 years, 9 months ago (2015-03-23 20:58:12 UTC) #1
abarth-chromium
sky/ LGTM
5 years, 9 months ago (2015-03-23 21:13:37 UTC) #2
Elliot Glaysher
lgtm
5 years, 9 months ago (2015-03-23 21:14:42 UTC) #3
sky
5 years, 9 months ago (2015-03-23 21:33:29 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
b5698886ded259610f083ae1f5339102d92ff857 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698