Histogram for UMA log upload connection type.

chrome/browser/metrics/chrome_metrics_service_client.h

Index: chrome/browser/metrics/chrome_metrics_service_client.h
diff --git a/chrome/browser/metrics/chrome_metrics_service_client.h b/chrome/browser/metrics/chrome_metrics_service_client.h
index c2f1c6e8bb2635ac94eec52cdf81e7998415d383..74c67204d569167d8d0e56846c150c07c2860dfe 100644
--- a/chrome/browser/metrics/chrome_metrics_service_client.h
+++ b/chrome/browser/metrics/chrome_metrics_service_client.h
@@ -15,6 +15,7 @@
 #include "chrome/browser/metrics/metrics_memory_details.h"
 #include "chrome/browser/metrics/network_stats_uploader.h"
 #include "components/metrics/metrics_service_client.h"
+#include "components/metrics/net/network_metrics_provider.h"
 #include "components/metrics/profiler/tracking_synchronizer_observer.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
@@ -63,7 +64,7 @@ class ChromeMetricsServiceClient
   bool GetBrand(std::string* brand_code) override;
   metrics::SystemProfileProto::Channel GetChannel() override;
   std::string GetVersionString() override;
-  void OnLogUploadComplete() override;
+  void OnLogUploadComplete(bool upload_succeeded) override;
   void StartGatheringMetrics(const base::Closure& done_callback) override;
   void CollectFinalMetrics(const base::Closure& done_callback) override;
   scoped_ptr<metrics::MetricsLogUploader> CreateUploader(
@@ -172,9 +173,8 @@ class ChromeMetricsServiceClient
   // MemoryDetails.
   MemoryGrowthTracker memory_growth_tracker_;
 
-  // Callback to determine whether or not a cellular network is currently being
-  // used.
-  base::Callback<void(bool*)> cellular_callback_;
+  // The network metrics provider for determining network connection type.
+  const metrics::NetworkMetricsProvider* network_metrics_provider_;

[Ilya Sherman, 2015/03/24 00:14:23]

Please move this to be defined near where the other metrics providers are, and
document the lifetime expectations.

[gayane -on leave until 09-2017, 2015/03/24 20:45:55]

Done.

 
   base::WeakPtrFactory<ChromeMetricsServiceClient> weak_ptr_factory_;