Histogram for UMA log upload connection type.

net/base/network_change_notifier.h

Index: net/base/network_change_notifier.h
diff --git a/net/base/network_change_notifier.h b/net/base/network_change_notifier.h
index 964fcf3c4b9a3a050a8030fe65da8bd0b4b0a304..f852109e7e71ece78a785e45f392c2ed56469160 100644
--- a/net/base/network_change_notifier.h
+++ b/net/base/network_change_notifier.h
@@ -41,6 +41,9 @@ class NET_EXPORT NetworkChangeNotifier {
   //
   // A Java counterpart will be generated for this enum.
   // GENERATED_JAVA_ENUM_PACKAGE: org.chromium.net
+  //
+  // Used to record the connection type used for uploading UMA logs in UMA

[pauljensen, 2015/03/26 19:03:35]

This is used for lots and lots of things, including surfacing to web pages via
netinfo.  This sentence makes it sounds like it's used just for UMA typing.  Can
we adjust this to be clearer, perhaps something like "New enum values should
only be added to the end of the enum and no values should be modified or reused,
as this is reported via UMA."

[gayane -on leave until 09-2017, 2015/03/26 19:09:05]

Done.

+  // histogram. Due to use in histogram this should be an append-only enum.
   enum ConnectionType {
     CONNECTION_UNKNOWN = 0,  // A connection exists, but its type is unknown.
                              // Also used as a default value.