Histogram for UMA log upload connection type.

components/metrics/net/net_metrics_log_uploader.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/metrics/net/net_metrics_log_uploader.h"
 
 #include "base/metrics/histogram.h"
 #include "net/base/load_flags.h"
+#include "net/base/network_change_notifier.h"
 #include "net/url_request/url_fetcher.h"
 #include "url/gurl.h"
 
+namespace {
+
+// Records the network connection type if upload was successful.
+void RecordConnectionType(int response_code) {
+  if (response_code == 200) {
+    UMA_HISTOGRAM_ENUMERATION("UMA.LogUpload.ConnetionType",
+                              net::NetworkChangeNotifier::GetConnectionType(),
+                              net::NetworkChangeNotifier::CONNECTION_LAST);

[Ilya Sherman, 2015/03/25 23:10:00]

If you reuse this enum, please add a comment above the enum definition warning
readers that the enum is used to back a histogram, and hence should be treated
as append-only.

[gayane -on leave until 09-2017, 2015/03/26 17:41:27]

Done.

+  }
+}

[Ilya Sherman, 2015/03/25 23:10:00]

nit: Please leave a blank line after this one.

[gayane -on leave until 09-2017, 2015/03/26 17:41:27]

Done.

+}

[Ilya Sherman, 2015/03/25 23:10:00]

nit: Please add a comment "  // namespace"

[gayane -on leave until 09-2017, 2015/03/26 17:41:27]

Done.

+
 namespace metrics {
 
 NetMetricsLogUploader::NetMetricsLogUploader(
     net::URLRequestContextGetter* request_context_getter,
     const std::string& server_url,
     const std::string& mime_type,
     const base::Callback<void(int)>& on_upload_complete)
     : MetricsLogUploader(server_url, mime_type, on_upload_complete),
       request_context_getter_(request_context_getter) {
 }
@@ skipping 25 matching lines @@
 void NetMetricsLogUploader::OnURLFetchComplete(const net::URLFetcher* source) {
   // We're not allowed to re-use the existing |URLFetcher|s, so free them here.
   // Note however that |source| is aliased to the fetcher, so we should be
   // careful not to delete it too early.
   DCHECK_EQ(current_fetch_.get(), source);
 
   int response_code = source->GetResponseCode();
   if (response_code == net::URLFetcher::RESPONSE_CODE_INVALID)
     response_code = -1;
   current_fetch_.reset();
+  RecordConnectionType(response_code);
   on_upload_complete_.Run(response_code);
 }
 
 }  // namespace metrics