Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1033453005: Revert of Filter invalid slots out from the SlotsBuffer after marking. (Closed)

Created:
5 years, 9 months ago by Michael Achenbach
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Filter invalid slots out from the SlotsBuffer after marking. (patchset #6 id:220001 of https://codereview.chromium.org/1010363005/) Reason for revert: Need to revert in order to revert https://codereview.chromium.org/1029323003/ Original issue's description: > Filter invalid slots out from the SlotsBuffer after marking. > > There are two reasons that could cause invalid slots appearance in SlotsBuffer: > 1) If GC trims "tail" of an array for which it has already recorded a slots and then migrate another object to the "tail". > 2) Tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). > > This CL also adds useful machinery that helps triggering incremental write barriers. > > BUG=chromium:454297 > LOG=Y > > Committed: https://crrev.com/5c47c1c0d3e4a488f190c16a64ee02f5a14e6561 > Cr-Commit-Position: refs/heads/master@{#27423} TBR=hpayer@chromium.org,erik.corry@gmail.com,ishell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:454297 Committed: https://crrev.com/4629f8023a56ea4a013757f750132052289800fe Cr-Commit-Position: refs/heads/master@{#27426}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -404 lines) Patch
M src/flag-definitions.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/heap/mark-compact.h View 3 chunks +3 lines, -14 lines 0 comments Download
M src/heap/mark-compact.cc View 9 chunks +22 lines, -157 lines 0 comments Download
M src/heap/spaces.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/heap/store-buffer.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 2 chunks +0 lines, -213 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Filter invalid slots out from the SlotsBuffer after marking.
5 years, 9 months ago (2015-03-24 22:01:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033453005/1
5 years, 9 months ago (2015-03-24 22:01:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 22:01:26 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 22:01:51 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4629f8023a56ea4a013757f750132052289800fe
Cr-Commit-Position: refs/heads/master@{#27426}

Powered by Google App Engine
This is Rietveld 408576698