Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1033453003: Remove SkClipStack's manual rounding of BW clip rects (Closed)

Created:
5 years, 9 months ago by robertphillips
Modified:
5 years, 9 months ago
Reviewers:
bsalomon, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SkClipStack's manual rounding of BW clip rects The full fix for this bug is nudging the image in device space. That is going to be a large change. This CL should address the immediate problem. This CL will alter the following GMs: clipdrawdraw convex_poly_clip complexclip_bw_* filltypespersp complexclip3_simple BUG=423834 Committed: https://skia.googlesource.com/skia/+/e523d4f90c3368c555282a98b41ca5ee2045103e

Patch Set 1 #

Patch Set 2 : Add fix for disappearing clip rects #

Patch Set 3 : Revert unneeded changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M src/core/SkClipStack.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
bsalomon
On 2015/03/24 16:03:11, robertphillips wrote: > mailto:robertphillips@google.com changed reviewers: > + mailto:bsalomon@google.com lgtm
5 years, 9 months ago (2015-03-24 16:04:31 UTC) #2
robertphillips
5 years, 9 months ago (2015-03-24 20:53:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033453003/80001
5 years, 9 months ago (2015-03-25 15:25:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033453003/80001
5 years, 9 months ago (2015-03-25 16:11:24 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:80001) as https://skia.googlesource.com/skia/+/e523d4f90c3368c555282a98b41ca5ee2045103e
5 years, 9 months ago (2015-03-25 16:11:33 UTC) #13
robertphillips
5 years, 8 months ago (2015-03-30 15:09:39 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:80001) has been created in
https://codereview.chromium.org/1045853002/ by robertphillips@google.com.

The reason for reverting is: Reverting due to performance regression:
https://code.google.com/p/skia/issues/detail?id=3597.

Powered by Google App Engine
This is Rietveld 408576698