Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Unified Diff: lib/src/codegen/js_codegen.dart

Issue 1033443003: Add missing visit methods (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/codegen/js_codegen.dart
diff --git a/lib/src/codegen/js_codegen.dart b/lib/src/codegen/js_codegen.dart
index d259e7269d9204af1d50fb53e5c9884fc9f67d6d..52ce19ff9d6eae4429a26384a617b84e2ffab0b0 100644
--- a/lib/src/codegen/js_codegen.dart
+++ b/lib/src/codegen/js_codegen.dart
@@ -295,6 +295,10 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ConversionVisitor {
return _finishClassDef(classElem, body);
}
+ @override
+ JS.Statement visitEnumDeclaration(EnumDeclaration node) =>
+ _unimplementedCall("Unimplemented enum: $node").toStatement();
+
/// Given a class element and body, complete the class declaration.
/// This handles generic type parameters, laziness (in library-cycle cases),
/// and ensuring dependencies are loaded first.
@@ -1956,6 +1960,10 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ConversionVisitor {
JS.Expression visitExpression(Expression node) =>
_unimplementedCall('Unimplemented ${node.runtimeType}: $node');
+ @override
+ JS.Statement visitYieldStatement(YieldStatement node) =>
+ _unimplementedCall('Unimplemented yield: $node').toStatement();
+
JS.Expression _unimplementedCall(String comment) {
return js.call('dart.throw_(#)', [js.escapedString(comment)]);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698