Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4005)

Unified Diff: extensions/renderer/resources/guest_view/web_view/web_view_attributes.js

Issue 1033373003: GuestView: Lazily push attributes to the browser process on attach (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_sizing
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/guest_view/web_view/web_view_attributes.js
diff --git a/extensions/renderer/resources/guest_view/web_view/web_view_attributes.js b/extensions/renderer/resources/guest_view/web_view/web_view_attributes.js
index ce538fdc3df3c2ff51c44d006036eae868eed295..551706e102c7cc6232f121edbf75f487a74b125d 100644
--- a/extensions/renderer/resources/guest_view/web_view/web_view_attributes.js
+++ b/extensions/renderer/resources/guest_view/web_view/web_view_attributes.js
@@ -199,10 +199,12 @@ SrcAttribute.prototype.handleMutation = function(oldValue, newValue) {
};
SrcAttribute.prototype.attach = function() {
+ GuestViewAttributes.Attribute.prototype.attach.call(this);
paulmeyer 2015/03/27 22:40:40 Why are these calls to the base attach/detach need
Fady Samuel 2015/03/27 22:56:36 They're unnecessary. They're remnants from an olde
this.parse();
};
SrcAttribute.prototype.detach = function() {
+ GuestViewAttributes.Attribute.prototype.detach.call(this);
paulmeyer 2015/03/27 22:40:40 See above.
Fady Samuel 2015/03/27 22:56:36 Done.
this.beforeFirstNavigation = true;
};

Powered by Google App Engine
This is Rietveld 408576698