Remove 150% hard line length limit for long URLs.

presubmit_canned_checks.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 import os as _os
 _HERE = _os.path.dirname(_os.path.abspath(__file__))
 
 # Justifications for each filter:
@@ skipping 350 matching lines @@
     file_maxlen = maxlens.get(file_extension, maxlens[''])
     # Stupidly long symbols that needs to be worked around if takes 66% of line.
     long_symbol = file_maxlen * 2 / 3
     # Hard line length limit at 50% more.
     extra_maxlen = file_maxlen * 3 / 2
 
     line_len = len(line)
     if line_len <= file_maxlen:
       return True
 
+    # Allow long URLs of any length.
+    if any((url in line) for url in ('file://', 'http://', 'https://')):
+      return True
+
     if line_len > extra_maxlen:
       return False
 
-    if any((url in line) for url in ('file://', 'http://', 'https://')):
-      return True
-
     if 'url(' in line and file_extension == 'css':
       return True
 
     if '<include' in line and file_extension in ('css', 'html', 'js'):
       return True
 
     return input_api.re.match(
         r'.*[A-Za-z][A-Za-z_0-9]{%d,}.*' % long_symbol, line)
 
   def format_error(filename, line_num, line):
@@ skipping 733 matching lines @@
   for f in affected_files:
     cmd = ['gn', 'format', '--dry-run', f.AbsoluteLocalPath()]
     rc = gn.main(cmd)
     if rc == 2:
       warnings.append(output_api.PresubmitPromptWarning(
           '%s requires formatting. Please run `gn format --in-place %s`.' % (
               f.AbsoluteLocalPath(), f.LocalPath())))
   # It's just a warning, so ignore other types of failures assuming they'll be
   # caught elsewhere.
   return warnings