Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1033333002: Remove duplicate definition of Protocol Handler support URL (Closed)

Created:
5 years, 9 months ago by tomc
Modified:
5 years, 9 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/lkgr
Project:
chromium
Visibility:
Public.

Description

Remove duplicate definition of Protocol Handler support URL A URL constant pointing to https://support.google.com/chrome/answer/1382847 existed in both handler_options_handler.cc and url_constants.cc. This removes the definition in handler_options_handler.cc. BUG=471318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M chrome/browser/ui/webui/options/handler_options_handler.cc View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
tomc
Hey James, Just a note, the constant defined in handler_options_handler.cc (https://support.google.com/chrome/answer/1382847) isn't actually identical to ...
5 years, 9 months ago (2015-03-27 18:46:45 UTC) #2
James Hawkins
lgtm
5 years, 9 months ago (2015-03-27 20:25:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033333002/1
5 years, 9 months ago (2015-03-27 20:51:44 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true in order for the CQ ...
5 years, 9 months ago (2015-03-27 20:51:47 UTC) #7
tomc
On 2015/03/27 20:51:47, I haz the power (commit-bot) wrote: > CLs for remote refs other ...
5 years, 9 months ago (2015-03-27 21:02:05 UTC) #8
James Hawkins
On 2015/03/27 21:02:05, tomc wrote: > On 2015/03/27 20:51:47, I haz the power (commit-bot) wrote: ...
5 years, 9 months ago (2015-03-27 21:03:27 UTC) #9
tomc
5 years, 9 months ago (2015-03-27 21:24:23 UTC) #10
Message was sent while issue was closed.
On 2015/03/27 21:03:27, James Hawkins wrote:
> On 2015/03/27 21:02:05, tomc wrote:
> > On 2015/03/27 20:51:47, I haz the power (commit-bot) wrote:
> > > CLs for remote refs other than refs/pending/heads/master must contain
> > NOTRY=true
> > > in order for the CQ to process them
> > 
> > 
> > Oops. I seem to have uploaded this CL from lkgr. Any way for me to recover
> this
> > issue or do I have to make a duplicate that is posted from the correct
branch?
> 
> I'm not sure.  You might need to ask chromium-dev.

Closed in favor of https://codereview.chromium.org/1044493002/

Powered by Google App Engine
This is Rietveld 408576698